public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Tom Rini <trini@kernel.crashing.org>
Cc: Linus Torvalds <torvalds@transmeta.com>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Cleanup i386 <linux/init.h> abuses
Date: Fri, 7 Jun 2002 13:01:45 +0200	[thread overview]
Message-ID: <20020607110145.GA9975@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.33.0206021853030.1383-100000@penguin.transmeta.com> <20020605163614.GF1335@opus.bloom.county>

Hi!

> The following patch cleans up the i386 usage of <linux/init.h>.
> This remove <linux/init.h> from <asm-i386/system.h> which did not need
> it, <asm-i386/highmem.h> which only had it due to an extern using
> __init, which is not needed.
> This adds <linux/init.h> to <asm-i386/bugs.h> which actually has
> numerous __init functions and adds <linux/init.h> to 9 files inside of
> arch/i386 which were indirectly including <linux/init.h> previously.


@@ -33,7 +32,7 @@
 extern pgprot_t kmap_prot;
 extern pte_t *pkmap_page_table;

-extern void kmap_init(void) __init;
+extern void kmap_init(void);

 /*
  * Right now we initialize only a single pte table. It can be
extended


__init is usefull as a documentation... Perhaps adding /* This is
__init function */ would be good.
									Pavel

-- 
(about SSSCA) "I don't say this lightly.  However, I really think that the U.S.
no longer is classifiable as a democracy, but rather as a plutocracy." --hpa

  reply	other threads:[~2002-06-07 19:11 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-03  1:56 Linux 2.5.20 Linus Torvalds
2002-06-03  3:06 ` 2.5.20 -- suspend.c still breaks the build (originally reported for 2.5.18) Miles Lane
2002-06-04 14:06   ` Pavel Machek
2002-06-03  3:18 ` [patch] i386 "General Options" - begone [take 2] Brad Hards
2002-06-03 22:42   ` Rusty Russell
2002-06-04 14:09   ` Pavel Machek
2002-06-04 22:05     ` Brad Hards
2002-06-02  5:16       ` Pavel Machek
2002-06-03 13:34 ` Oops Linux 2.5.20 Martin Dalecki
2002-06-03 14:06 ` [PATCH] 2.5.20 airo wireless - "I can't get no, compilation..." Martin Dalecki
2002-06-03 14:09 ` ]PATCH] 2.5.20 IDE 83 Martin Dalecki
2002-06-04 12:07   ` Jens Axboe
2002-06-04 15:30 ` [PATCH] 2.5.20 IDE 84 Martin Dalecki
2002-06-05 13:03 ` [PATCH] 2.5.20 IDE 85 Martin Dalecki
2002-06-05 14:17   ` Jens Axboe
2002-06-05 14:00     ` Martin Dalecki
2002-06-05 15:48       ` Jens Axboe
2002-06-05 15:52         ` Jens Axboe
2002-06-05 15:10           ` Martin Dalecki
2002-06-05 16:14             ` Jens Axboe
2002-06-05 15:26               ` Martin Dalecki
2002-06-05 18:02               ` Jeff Garzik
2002-06-06  7:17           ` Martin Dalecki
2002-06-05 16:36 ` [PATCH] Cleanup i386 <linux/init.h> abuses Tom Rini
2002-06-07 11:01   ` Pavel Machek [this message]
2002-06-07 19:19     ` Thunder from the hill
2002-06-07 19:26     ` Tom Rini
2002-06-05 23:22 ` [PATCH] Add <linux/kdev_t.h> to <linux/bio.h> Tom Rini
2002-06-05 23:34   ` Russell King
2002-06-05 23:42     ` Tom Rini
2002-06-06 18:33 ` [PATCH] Move vmalloc wrappers out of include/linux/vmalloc.h Tom Rini
2002-06-06 19:44 ` [PATCH] Remove <linux/mm.h> from <linux/vmalloc.h> Tom Rini
2002-06-06 21:02   ` [PATCH] More work on removing " Tom Rini
2002-06-06 21:21 ` [PATCH] Include <linux/gfp.h> directly instead of via <linux/mm.h> Tom Rini
2002-06-06 21:24 ` [PATCH] Remove numerous includes from <linux/mm.h> Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020607110145.GA9975@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=trini@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox