From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org, frankeh@watson.ibm.com,
alan@lxorguk.ukuu.org.uk, viro@math.psu.edu
Subject: Re: [PATCH] Futex Asynchronous Interface
Date: Fri, 7 Jun 2002 19:06:50 +1000 [thread overview]
Message-ID: <20020607190650.57f25467.rusty@rustcorp.com.au> (raw)
In-Reply-To: <Pine.LNX.4.44.0206060930240.5920-100000@home.transmeta.com>
On Thu, 6 Jun 2002 09:36:23 -0700 (PDT)
Linus Torvalds <torvalds@transmeta.com> wrote:
> You already have to have a system call to bind the particular fd to the
> futex _anyway_, so do the only sane thing, and allocate the fd _there_,
But Ma, I don't *want* to write a filesystem!
Linus, Al, is there an easier way to do this? I stole this from sockfs,
but I balked at another 50 lines for a proper inode creation, so I just use
the same dentry and inode over and over.
It's still an awful lot of irrelevant code: what can I cut?
/* Everyone needs a dentry and inode */
static struct dentry *futex_dentry;
/* Signal allows caller to avoid the race which would occur if they
set the sigio stuff up afterwards. */
static int futex_fd(struct list_head *head,
struct page *page,
int offset,
int signal)
{
int fd;
struct futex_q *q;
struct file *filp;
if (signal < 0 || signal > _NSIG)
return -EINVAL;
fd = get_unused_fd();
if (fd < 0)
return fd;
filp = get_empty_filp();
if (!filp) {
put_unused_fd(fd);
return -ENFILE;
}
filp->f_op = &futex_fops;
filp->f_dentry = dget(futex_dentry);
if (signal) {
filp->f_owner.pid = current->pid;
filp->f_owner.uid = current->uid;
filp->f_owner.euid = current->euid;
filp->f_owner.signum = signal;
}
q = kmalloc(sizeof(*q), GFP_KERNEL);
if (!q) {
put_unused_fd(fd);
put_filp(filp);
return -ENOMEM;
}
/* Initialize queue structure */
init_waitqueue_head(&q->waiters);
filp->private_data = q;
/* Go for it... */
queue_me(head, q, page, offset, fd, filp);
/* Now we map fd to filp, so userspace can access it */
fd_install(fd, filp);
return 0;
}
/* Oh yeah, makes sense to write a filesystem... */
static struct super_operations futexfs_ops = {
statfs: simple_statfs,
};
static int futexfs_fill_super(struct super_block *sb, void *data, int silent)
{
struct inode *root;
sb->s_blocksize = 1024;
sb->s_blocksize_bits = 10;
sb->s_magic = 0xFBAD1DEA;
sb->s_op = &futexfs_ops;
root = new_inode(sb);
if (!root)
return -ENOMEM;
root->i_mode = S_IFDIR | S_IRUSR | S_IWUSR;
root->i_uid = root->i_gid = 0;
root->i_atime = root->i_mtime = root->i_ctime = CURRENT_TIME;
sb->s_root = d_alloc(NULL, &(const struct qstr) { "futex", 5, 0 });
if (!sb->s_root) {
iput(root);
return -ENOMEM;
}
sb->s_root->d_sb = sb;
sb->s_root->d_parent = sb->s_root;
d_instantiate(sb->s_root, root);
return 0;
}
static struct super_block *
futexfs_get_sb(struct file_system_type *fs_type,
int flags, char *dev_name, void *data)
{
return get_sb_nodev(fs_type, flags, data, futexfs_fill_super);
}
static struct file_system_type futex_fs_type = {
name: "futexfs",
get_sb: futexfs_get_sb,
kill_sb: kill_anon_super,
fs_flags: FS_NOMOUNT,
};
static int __init init(void)
{
unsigned int i;
struct qstr name = { .name = "futex", .len = 5, .hash = 0 };
struct vfsmount *futex_mnt;
register_filesystem(&futex_fs_type);
futex_mnt = kern_mount(&futex_fs_type);
futex_dentry = d_alloc(NULL, &name);
futex_dentry->d_inode = new_inode(futex_mnt->mnt_sb);
for (i = 0; i < ARRAY_SIZE(futex_queues); i++)
INIT_LIST_HEAD(&futex_queues[i]);
return 0;
}
__initcall(init);
--
there are those who do and those who hang on and you don't see too
many doers quoting their contemporaries. -- Larry McVoy
next prev parent reply other threads:[~2002-06-07 9:55 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-06 7:26 [PATCH] Futex Asynchronous Interface Rusty Russell
2002-06-02 0:10 ` Pavel Machek
2002-06-10 6:57 ` Rusty Russell
2002-06-06 16:36 ` Linus Torvalds
2002-06-06 19:27 ` Alan Cox
2002-06-06 23:21 ` Rusty Russell
2002-06-07 8:33 ` Peter Wächtler
2002-06-08 22:28 ` Linus Torvalds
2002-06-09 9:49 ` Kai Henningsen
2002-06-09 18:09 ` Linus Torvalds
2002-06-09 19:06 ` Thunder from the hill
2002-06-10 6:39 ` Kai Henningsen
2002-06-10 7:55 ` Helge Hafting
2002-06-10 14:10 ` Thunder from the hill
2002-06-10 20:46 ` Kai Henningsen
2002-06-11 14:14 ` john slee
2002-06-10 15:11 ` Linus Torvalds
2002-06-11 15:06 ` Eric W. Biederman
2002-06-10 20:57 ` H. Peter Anvin
2002-06-09 10:07 ` Peter Wächtler
2002-06-09 17:49 ` Linus Torvalds
2002-06-07 9:06 ` Rusty Russell [this message]
2002-06-08 22:42 ` Linus Torvalds
2002-06-11 9:15 ` Rusty Russell
2002-06-11 16:53 ` Linus Torvalds
2002-06-12 5:32 ` Rusty Russell
2002-06-12 9:16 ` Peter Wächtler
2002-06-12 14:19 ` Hubertus Franke
2002-06-12 16:50 ` Peter Wächtler
2002-06-12 18:15 ` Vladimir Zidar
2002-06-12 15:39 ` Linus Torvalds
2002-06-12 16:29 ` Peter Wächtler
2002-06-12 16:52 ` Linus Torvalds
2002-06-12 17:07 ` Peter Wächtler
2002-06-12 18:32 ` Saurabh Desai
2002-06-12 20:05 ` Oliver Xymoron
2002-06-12 20:16 ` Linus Torvalds
2002-06-13 2:57 ` Rusty Russell
2002-06-13 9:37 ` Peter Wächtler
2002-06-13 9:55 ` Rusty Russell
2002-06-13 16:38 ` Gabriel Paubert
2002-06-13 16:40 ` Linus Torvalds
2002-06-13 1:32 ` Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2002-06-06 16:08 Martin Wirth
2002-06-06 22:59 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020607190650.57f25467.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=frankeh@watson.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox