From: Dawson Engler <engler@csl.Stanford.EDU>
To: bhards@bigpond.net.au (Brad Hards)
Cc: linux-kernel@vger.kernel.org, mc@cs.Stanford.EDU
Subject: Re: [CHECKER] 54 missing null pointer checks in 2.4.17
Date: Mon, 10 Jun 2002 00:08:46 -0700 (PDT) [thread overview]
Message-ID: <200206100708.AAA19223@csl.Stanford.EDU> (raw)
In-Reply-To: <200206101703.13780.bhards@bigpond.net.au> from "Brad Hards" at Jun 10, 2002 05:03:13 PM
> Thanks for these. Patch for 2.4.19-pre10 to fix catc and se401 bugs currently
> compile testing :)
Good deal! Thanks for letting us know.
> > se401->width=kmalloc(se401->sizes*sizeof(int), GFP_KERNEL);
> > se401->height=kmalloc(se401->sizes*sizeof(int), GFP_KERNEL);
> > for (i=0; i<se401->sizes; i++) {
> > se401->width[i]=cp[6+i*4+0]+cp[6+i*4+1]*256;
> > se401->height[i]=cp[6+i*4+2]+cp[6+i*4+3]*256;
> > }
> > sprintf (temp, "%s Sizes:", temp);
> > for (i=0; i<se401->sizes; i++) {
> > Error --->
> > sprintf(temp, "%s %dx%d", temp, se401->width[i], se401->height[i]);
> > }
> > info("%s", temp);
> > se401->maxframesize=se401->width[se401->sizes-1]*se401->height[se401->size
> >s-1]*3; ---------------------------------------------------------
> bradh: this one is wrong. If it didn't oops on the previous one, it won't oops
> here :)
Yeah, indeed. The current rewrite doesn't (yet) have false path suppression
back in and I'm getting too old to be reliable. Thanks for pointing it
out.
next prev parent reply other threads:[~2002-06-10 7:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-10 3:55 [CHECKER] 54 missing null pointer checks in 2.4.17 Dawson Engler
2002-06-10 5:22 ` Kasper Dupont
2002-06-10 5:56 ` Dawson Engler
2002-06-10 5:28 ` Andreas Dilger
2002-06-10 6:07 ` Dawson Engler
2002-06-10 6:35 ` Andreas Dilger
2002-06-10 7:05 ` Dawson Engler
2002-06-10 7:19 ` Giuliano Pochini
2002-06-10 12:40 ` john slee
2002-06-10 7:03 ` Brad Hards
2002-06-10 7:08 ` Dawson Engler [this message]
2002-06-11 0:30 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200206100708.AAA19223@csl.Stanford.EDU \
--to=engler@csl.stanford.edu \
--cc=bhards@bigpond.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.Stanford.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox