From: Greg KH <greg@kroah.com>
To: Dawson Engler <engler@csl.Stanford.EDU>
Cc: linux-kernel@vger.kernel.org, mc@cs.Stanford.EDU
Subject: Re: [CHECKER] 54 missing null pointer checks in 2.4.17
Date: Mon, 10 Jun 2002 17:30:04 -0700 [thread overview]
Message-ID: <20020611003004.GF5202@kroah.com> (raw)
In-Reply-To: <200206100355.UAA17040@csl.Stanford.EDU>
On Sun, Jun 09, 2002 at 08:55:22PM -0700, Dawson Engler wrote:
> ---------------------------------------------------------
> [BUG]
> /u2/engler/mc/oses/linux/2.4.17/drivers/hotplug/cpqphp_proc.c:156:cpqhp_proc_create_ctrl: ERROR:NULL:155:156:Using ptr "(*ctrl).proc_entry" illegally! set by 'create_proc_entry':155 [COUNTER=create_proc_entry:155] [fit=7] [fit_fn=1] [fn_ex=0] [fn_counter=1] [ex=88] [counter=4] [z = 0.287018923940967] [fn-z = -4.35889894354067]
> int cpqhp_proc_create_ctrl (struct controller *ctrl)
> {
> strcpy(ctrl->proc_name, "hpca");
> ctrl->proc_name[3] = 'a' + ctrl->bus;
>
> Start --->
> ctrl->proc_entry = create_proc_entry(ctrl->proc_name, S_IFREG | S_IRUGO, ctrl_proc_root);
> Error --->
> ctrl->proc_entry->data = ctrl;
> ctrl->proc_entry->read_proc = &read_ctrl;
>
> strcpy(ctrl->proc_name2, "slot_a");
> ---------------------------------------------------------
> [BUG]
> /u2/engler/mc/oses/linux/2.4.17/drivers/hotplug/cpqphp_proc.c:162:cpqhp_proc_create_ctrl: ERROR:NULL:161:162:Using ptr "(*ctrl).proc_entry2" illegally! set by 'create_proc_entry':161 [COUNTER=create_proc_entry:161] [fit=7] [fit_fn=2] [fn_ex=0] [fn_counter=1] [ex=88] [counter=4] [z = 0.287018923940967] [fn-z = -4.35889894354067]
> ctrl->proc_entry->data = ctrl;
> ctrl->proc_entry->read_proc = &read_ctrl;
>
> strcpy(ctrl->proc_name2, "slot_a");
> ctrl->proc_name2[5] = 'a' + ctrl->bus;
> Start --->
> ctrl->proc_entry2 = create_proc_entry(ctrl->proc_name2, S_IFREG | S_IRUGO, ctrl_proc_root);
> Error --->
> ctrl->proc_entry2->data = ctrl;
> ctrl->proc_entry2->read_proc = &read_dev;
>
> return 0;
> ---------------------------------------------------------
Ah, good catch, I'll go fix these two.
thanks,
greg k-h
prev parent reply other threads:[~2002-06-11 0:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-10 3:55 [CHECKER] 54 missing null pointer checks in 2.4.17 Dawson Engler
2002-06-10 5:22 ` Kasper Dupont
2002-06-10 5:56 ` Dawson Engler
2002-06-10 5:28 ` Andreas Dilger
2002-06-10 6:07 ` Dawson Engler
2002-06-10 6:35 ` Andreas Dilger
2002-06-10 7:05 ` Dawson Engler
2002-06-10 7:19 ` Giuliano Pochini
2002-06-10 12:40 ` john slee
2002-06-10 7:03 ` Brad Hards
2002-06-10 7:08 ` Dawson Engler
2002-06-11 0:30 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020611003004.GF5202@kroah.com \
--to=greg@kroah.com \
--cc=engler@csl.Stanford.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.Stanford.EDU \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox