From: "David S. Miller" <davem@redhat.com>
To: david-b@pacbell.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: PCI DMA to small buffers on cache-incoherent arch
Date: Wed, 12 Jun 2002 02:22:58 -0700 (PDT) [thread overview]
Message-ID: <20020612.022258.81407248.davem@redhat.com> (raw)
In-Reply-To: <3D06F2FF.8070109@pacbell.net>
From: David Brownell <david-b@pacbell.net>
Date: Wed, 12 Jun 2002 00:06:39 -0700
David S. Miller wrote:
> 0 is a valid PCI dma address on many platforms. This is part
> of the problem.
OK, so a new call syntax would be desirable. Or reserving page zero
even on such platforms.
Or, better yet, define a PCI_BAD_ADDR per-arch.
> Huh? The whole idea is that it is memory for PCI dma, it has to be
> PCI in nature. If you want a kmalloc'ish thing, simple use
> pci_alloc_consistent and carve up the pages you get internally.
And the reason that logic doesn't lead us to rip kmalloc() out of
the kernel (in favor of the page allocator) is ... what? Every driver
shouldn't _need_ to write yet another malloc() clone, that's all I'm
saying; that'd be a waste.
That is why we have the PCI pool thing, it's PCI alloc consistent +
SLAB carving.
Certainly hanging some sort of memory allocator object off struct device
should be pretty cheap. At least for USB, all devices on the same bus
could share the same allocator. Not that I know PCI that well, but I
suspect that could be true there too ... more sharing, less internal
fragmentation, and more efficient use of various resources.
These instances we are talking about want to allocate multiple
instance of the same object (thus the same size). They are not
allocating things like variable length strings and whatnot.
That is why I keep suggesting PCI pools, it's the perfect kind of
setup (and the easiest to implement). A generic kmalloc() out of
pages is more to implement, certainly.
If you want to hide this behind a usb_dma_pool_create,
usb_dma_pool_alloc etc. kind of interface that calls back into the
host controller layer to get the pci_dev etc., that's fine.
Now enough talking and someone implement this, talk is cheap.
next prev parent reply other threads:[~2002-06-12 9:28 UTC|newest]
Thread overview: 102+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-11 5:31 PCI DMA to small buffers on cache-incoherent arch David Brownell
2002-06-11 5:44 ` David S. Miller
2002-06-11 15:12 ` David Brownell
2002-06-11 15:44 ` Oliver Neukum
2002-06-12 3:25 ` David S. Miller
2002-06-11 17:33 ` Benjamin Herrenschmidt
2002-06-12 9:42 ` David S. Miller
2002-06-12 14:14 ` David Brownell
2002-06-12 15:00 ` Benjamin Herrenschmidt
2002-06-12 18:44 ` Roland Dreier
2002-06-12 19:13 ` David Brownell
2002-06-12 19:58 ` Oliver Neukum
2002-06-12 22:51 ` David S. Miller
2002-06-12 23:17 ` Oliver Neukum
2002-06-13 4:57 ` David Brownell
2002-06-12 22:46 ` David S. Miller
2002-06-13 5:13 ` David Brownell
2002-06-13 9:38 ` David S. Miller
2002-06-12 22:50 ` David S. Miller
2002-06-13 0:23 ` [PATCH] 2.4 add __dma_buffer alignment macro Roland Dreier
2002-06-13 1:07 ` David S. Miller
2002-06-13 1:19 ` Roland Dreier
2002-06-12 6:25 ` PCI DMA to small buffers on cache-incoherent arch David Brownell
2002-06-12 6:24 ` David S. Miller
2002-06-12 7:06 ` David Brownell
2002-06-12 9:22 ` David S. Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-06-08 20:38 Roland Dreier
2002-06-08 13:58 ` Anton Blanchard
2002-06-09 0:52 ` Roland Dreier
2002-06-08 23:03 ` David S. Miller
2002-06-09 0:40 ` Roland Dreier
2002-06-09 0:53 ` David S. Miller
2002-06-09 1:26 ` Roland Dreier
2002-06-09 5:29 ` David S. Miller
2002-06-09 6:16 ` Roland Dreier
2002-06-10 16:03 ` Roland Dreier
2002-06-11 14:04 ` David Woodhouse
2002-06-09 6:45 ` Oliver Neukum
2002-06-10 4:24 ` David S. Miller
2002-06-10 10:00 ` Oliver Neukum
2002-06-10 10:24 ` David S. Miller
2002-06-09 9:51 ` Paul Mackerras
2002-06-09 10:54 ` Benjamin Herrenschmidt
2002-06-10 4:27 ` David S. Miller
2002-06-10 15:59 ` Roland Dreier
2002-06-10 17:03 ` Tom Rini
2002-06-10 17:22 ` Oliver Neukum
2002-06-10 17:29 ` Tom Rini
2002-06-10 17:39 ` Oliver Neukum
2002-06-10 19:03 ` Roland Dreier
2002-06-10 19:14 ` Tom Rini
2002-06-10 19:21 ` Roland Dreier
2002-06-10 19:26 ` Tom Rini
2002-06-10 17:57 ` Russell King
2002-06-10 17:28 ` Roland Dreier
2002-06-10 18:07 ` William Jhun
2002-06-10 18:29 ` William Jhun
2002-06-10 18:33 ` Mark Zealey
2002-06-10 18:44 ` Oliver Neukum
2002-06-11 3:10 ` David S. Miller
2002-06-11 4:04 ` Roland Dreier
2002-06-11 4:16 ` Brad Hards
2002-06-11 4:24 ` Roland Dreier
2002-06-11 4:24 ` David S. Miller
2002-06-11 4:21 ` David S. Miller
2002-06-11 4:39 ` Roland Dreier
2002-06-11 4:38 ` David S. Miller
2002-06-11 6:23 ` Oliver Neukum
2002-06-11 6:38 ` David S. Miller
2002-06-11 7:38 ` Oliver Neukum
2002-06-11 7:36 ` David S. Miller
2002-06-11 7:43 ` David S. Miller
2002-06-11 8:07 ` Oliver Neukum
2002-06-11 8:15 ` David S. Miller
2002-06-11 12:06 ` Oliver Neukum
2002-06-11 12:04 ` David S. Miller
2002-06-11 14:23 ` Oliver Neukum
2002-06-14 4:14 ` David S. Miller
2002-06-11 18:26 ` Roland Dreier
2002-06-11 17:29 ` Benjamin Herrenschmidt
2002-06-12 12:02 ` Oliver Neukum
2002-06-11 20:06 ` Benjamin Herrenschmidt
2002-06-12 12:02 ` David S. Miller
2002-06-11 23:00 ` Thunder from the hill
2002-06-11 23:56 ` Roland Dreier
2002-06-12 0:09 ` Thunder from the hill
2002-06-11 15:57 ` William Jhun
2002-06-12 9:06 ` Pavel Machek
2002-06-12 20:16 ` David S. Miller
2002-06-12 11:47 ` David S. Miller
2002-06-12 12:08 ` Oliver Neukum
2002-06-14 4:41 ` David S. Miller
2002-06-12 16:09 ` William Jhun
2002-06-09 1:30 ` Albert D. Cahalan
2002-06-09 5:29 ` David S. Miller
2002-06-09 6:33 ` Albert D. Cahalan
2002-06-09 6:50 ` Oliver Neukum
2002-06-09 6:57 ` Albert D. Cahalan
2002-06-09 7:15 ` Oliver Neukum
2002-06-09 8:48 ` Russell King
2002-06-09 15:42 ` Albert D. Cahalan
2002-06-09 23:26 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020612.022258.81407248.davem@redhat.com \
--to=davem@redhat.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox