From: Russell King <rmk@arm.linux.org.uk>
To: Denis Oliver Kropp <dok@directfb.org>
Cc: Linus Torvalds <torvalds@transmeta.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [2.5.21] CyberPro 32bit support and other fixes
Date: Thu, 13 Jun 2002 10:09:24 +0100 [thread overview]
Message-ID: <20020613100924.A24154@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20020613083243.GA32352@skunk.convergence.de>
On Thu, Jun 13, 2002 at 10:32:43AM +0200, Denis Oliver Kropp wrote:
> - * Integraphics CyberPro 2000, 2010 and 5000 frame buffer device
> + * Intergraphics CyberPro 2000, 2010 and 5000 frame buffer device
This isn't actually a spelling mistake. The chips I have are quite
clearly marked "Integraphics" not "Intergraphics".
> @@ -355,7 +367,9 @@
>
> if (regno < 16)
> ((u16 *)cfb->fb.pseudo_palette)[regno] =
> - regno | regno << 5 | regno << 11;
> + ((red << 8) & 0xf800) |
> + ((green << 3) & 0x07e0) |
> + ((blue >> 3));
> break;
> }
> #endif
This seems wrong. We're setting up the DAC palette to map pixel color
component 'regno' to 'read', 'green' and 'blue' respectively.
This means that the pseudopalette should be a 1:1 mapping of desired
colour value (ie, the 16 VGA colors) to the DAC palette entries -
the pseudopalette contains the pixel values to insert into the frame
buffer for each of the 16 VGA colors.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-06-13 9:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-13 8:32 [PATCH] [2.5.21] CyberPro 32bit support and other fixes Denis Oliver Kropp
2002-06-13 9:09 ` Russell King [this message]
2002-06-13 9:23 ` Denis Oliver Kropp
2002-06-14 22:53 ` James Simmons
2002-06-15 10:55 ` Denis Oliver Kropp
2002-06-15 12:30 ` Russell King
2002-06-15 14:03 ` Denis Oliver Kropp
2002-06-28 13:03 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020613100924.A24154@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=dok@directfb.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox