From: Petter <petter@kernelspace.com>
To: linux-kernel@vger.kernel.org
Subject: small 5575 PCI ATM fix
Date: Tue, 18 Jun 2002 15:35:27 +0200 [thread overview]
Message-ID: <20020618133527.GA11756@kernelspace.com> (raw)
I was grepping through some code, and noticed that the return value
of a kmalloc in iphase.c was not checked.
A patch was sendt to the author, but this was the reply I got:
"Peter Wang is no longer a member of the Interphase team. Interphase
does support the 5575 PCI ATM adapter with Linux, but for driver enhancements
and fixes, we require a current software warranty contract. If you
could send me the serial number and / or the MAC address of your adapter, I
can verify your warranty status and have the latest driver sent to you."
I do not care about their driver since I do not have an ATM card, but
the current driver should anyhow be fixed.
Please apply the patch below.
Regards
Petter Wahlman
--- linux-2.4.19-pre10/drivers/atm/iphase.c Mon Feb 25 20:37:57 2002
+++ linux-2.4.19-pre10-pw/drivers/atm/iphase.c Tue Jun 18 10:47:02 2002
@@ -2002,6 +2002,10 @@
}
iadev->desc_tbl = kmalloc(iadev->num_tx_desc *
sizeof(struct desc_tbl_t),
GFP_KERNEL);
+ if (!iadev->desc_tbl) {
+ printk(KERN_ERR DEV_LABEL " couldn't get mem\n");
+ return -EAGAIN;
+ }
/* Communication Queues base address */
i = TX_COMP_Q * iadev->memSize;
next reply other threads:[~2002-06-18 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-18 13:35 Petter [this message]
2002-06-18 13:58 ` small 5575 PCI ATM fix Dave Jones
2002-06-18 14:12 ` Petter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020618133527.GA11756@kernelspace.com \
--to=petter@kernelspace.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox