From: Petter <petter@kernelspace.com>
To: Dave Jones <davej@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: small 5575 PCI ATM fix
Date: Tue, 18 Jun 2002 16:12:42 +0200 [thread overview]
Message-ID: <20020618141242.GB11756@kernelspace.com> (raw)
In-Reply-To: <20020618155837.S758@suse.de>
On Tue, Jun 18, 2002 at 03:58:37PM +0200, Dave Jones wrote:
> On Tue, Jun 18, 2002 at 03:35:27PM +0200, Petter wrote:
> Error handling in that driver seems to be 'creative' at best.
I agree.
> No releasing of already allocated resources, just returning -EAGAIN
> everywhere, and no checking for already allocated resources.
>
> Someone with too much time on their hands[1] could probably clean this
> up to free allocated resources on failure and return -ENOMEM on
> allocation failures.
Yup, but I do not have that much spare time ;)
I just looked at the code for two seconds and thought that I'd send a
quick fix for it.
Regards
Petter Wahlman
prev parent reply other threads:[~2002-06-18 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-18 13:35 small 5575 PCI ATM fix Petter
2002-06-18 13:58 ` Dave Jones
2002-06-18 14:12 ` Petter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020618141242.GB11756@kernelspace.com \
--to=petter@kernelspace.com \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox