public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Felipe Contreras <al593181@mail.mty.itesm.mx>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Compaq hotplug fix for 2.5.23
Date: Wed, 19 Jun 2002 10:47:55 -0700	[thread overview]
Message-ID: <20020619174755.GC26136@kroah.com> (raw)
In-Reply-To: <20020619075300.GA1098@zion.mty.itesm.mx>

On Wed, Jun 19, 2002 at 02:53:00AM -0500, Felipe Contreras wrote:
> Hi,
> 
> This one makes posible to compile the compaq hotplug module.

But does it work?

The tqueue.h patch will fix the compile time error, but I would prefer
to put that in each .c file, and not in the .h file.

The call to run_sbin_hotplug will not bind any drivers that are already
present in the kernel to the new device.  It will only call
/sbin/hotplug, which is not all that is needed.

What needs to be done is to call the same function that CardBus calls,
and remove a lot of the pci device initialization from the compaq (and
IBM) pci hotplug drivers.

It's on my list of things to do, but pretty far down, patches gladly
accepted :)

thanks,

greg k-h

      reply	other threads:[~2002-06-19 17:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-19  7:53 [PATCH] Compaq hotplug fix for 2.5.23 Felipe Contreras
2002-06-19 17:47 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020619174755.GC26136@kroah.com \
    --to=greg@kroah.com \
    --cc=al593181@mail.mty.itesm.mx \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox