From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 19 Jun 2002 14:22:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 19 Jun 2002 14:22:04 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:40159 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id ; Wed, 19 Jun 2002 14:22:03 -0400 Date: Wed, 19 Jun 2002 20:21:47 +0200 From: Jens Axboe To: Zwane Mwaikambo Cc: Linux Kernel , Martin Dalecki Subject: Re: Oops on 2.5.23 and IDE Message-ID: <20020619182147.GG812@suse.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 19 2002, Zwane Mwaikambo wrote: > Hi Martin, > IDE seems to be doing odd things. > > >>EIP; c0117318 <===== > Trace; c0117c6a > Trace; c0117820 > Trace; c0117820 > Trace; c022e1ae > Trace; c01bc082 > Trace; c022e439 > Trace; c02302f4 > Trace; c022e1d0 > Trace; c0234e75 > Trace; c0231138 > Trace; c0234d60 > > > int ide_do_drive_cmd() > { > [...] > if (action == ide_wait) { > wait_for_completion(&wait); /* wait for it to be serviced */ > return rq->errors ? -EIO : 0; /* return -EIO if errors */ > } > [...] > } > > Was that function really designed to be called from interrupt context? With action other than ide_wait sure, using ide_wait of course not. -- Jens Axboe