From: Andreas Dilger <adilger@clusterfs.com>
To: Daniel Phillips <phillips@bonn-fries.net>
Cc: Christopher Li <chrisl@gnuchina.org>,
"Stephen C. Tweedie" <sct@redhat.com>,
Alexander Viro <viro@math.psu.edu>, DervishD <raul@pleyades.net>,
Linux-kernel <linux-kernel@vger.kernel.org>,
ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] Re: Shrinking ext3 directories
Date: Wed, 19 Jun 2002 18:24:20 -0600 [thread overview]
Message-ID: <20020620002420.GG22427@clusterfs.com> (raw)
In-Reply-To: <E17KoGz-0000y5-00@starship>
On Jun 20, 2002 00:49 +0200, Daniel Phillips wrote:
> My inclination is to copy the last block of the directory into the
> vacated block as opposed to leaving a hole in the file. The slight
> extra cost doesn't seem to be worth worrying about, and it's guaranteed
> to leave the directory in a compact state when emptied.
This also has the benefit of avoiding huge truncates when we are
deleting lots of files. At most it will add a single block into
each transaction.
> I think it's best to err on the side of simplicity this time: the
> copy-down-last strategy eliminates the need to search for a free
> block when the directory needs to be expanded again,
It also keeps compatibility with older code, whereas having holes in
directories can cause problems on older kernels.
Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/
next prev parent reply other threads:[~2002-06-20 0:27 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-18 16:08 Shrinking ext3 directories DervishD
2002-06-18 16:10 ` Austin Gonyou
2002-06-18 16:39 ` Andreas Dilger
2002-06-18 19:39 ` DervishD
2002-06-18 19:34 ` DervishD
2002-06-18 16:21 ` Padraig Brady
2002-06-18 16:54 ` David Lang
2002-06-18 19:35 ` DervishD
2002-06-18 21:50 ` Stephen C. Tweedie
2002-06-18 22:18 ` Alexander Viro
2002-06-19 9:38 ` DervishD
2002-06-19 10:37 ` Stephen C. Tweedie
2002-06-19 17:03 ` [Ext2-devel] " Christopher Li
2002-06-19 20:10 ` Stephen C. Tweedie
2002-06-19 20:34 ` Stephen C. Tweedie
2002-06-19 20:13 ` Andrew Morton
2002-06-19 22:43 ` Stephen C. Tweedie
2002-06-19 23:54 ` Stephen C. Tweedie
2002-06-21 3:28 ` Daniel Phillips
2002-06-21 7:03 ` Helge Hafting
2002-06-21 14:02 ` Daniel Phillips
2002-06-24 7:12 ` Helge Hafting
2002-06-21 16:23 ` Daniel Phillips
2002-06-21 15:06 ` Stephen C. Tweedie
2002-07-04 4:48 ` Daniel Phillips
2002-07-04 14:15 ` jlnance
2002-07-05 2:11 ` Daniel Phillips
2002-06-22 5:53 ` Andreas Dilger
2002-06-22 20:59 ` Daniel Phillips
2002-06-23 0:01 ` Daniel Phillips
2002-06-23 7:57 ` Daniel Phillips
2002-06-19 22:49 ` Daniel Phillips
2002-06-20 0:24 ` Andreas Dilger [this message]
2002-06-20 9:34 ` Stephen C. Tweedie
2002-06-20 10:18 ` Andreas Dilger
2002-06-20 13:45 ` Daniel Phillips
2002-06-21 14:54 ` Ville Herva
2002-06-21 15:08 ` Stephen C. Tweedie
2002-06-21 15:38 ` Ville Herva
2002-06-21 16:15 ` Stephen C. Tweedie
2002-06-21 18:44 ` Ville Herva
2002-06-20 16:26 ` Bill Davidsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020620002420.GG22427@clusterfs.com \
--to=adilger@clusterfs.com \
--cc=chrisl@gnuchina.org \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@bonn-fries.net \
--cc=raul@pleyades.net \
--cc=sct@redhat.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox