From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Thu, 20 Jun 2002 05:20:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Thu, 20 Jun 2002 05:20:04 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:19912 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id ; Thu, 20 Jun 2002 05:20:03 -0400 Date: Thu, 20 Jun 2002 11:19:48 +0200 From: Jens Axboe To: Martin Dalecki Cc: Bartlomiej Zolnierkiewicz , Paul Bristow , Gadi Oxman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.5.22] simple ide-tape.c and ide-floppy.c cleanup Message-ID: <20020620091948.GB16466@suse.de> References: <20020620054230.GK812@suse.de> <3D119D5B.8060202@evision-ventures.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3D119D5B.8060202@evision-ventures.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 20 2002, Martin Dalecki wrote: > U?ytkownik Jens Axboe napisa?: > >On Wed, Jun 19 2002, Bartlomiej Zolnierkiewicz wrote: > > > >Looks pretty good in general, just one minor detail: > > > > > >>+ > >>+/* > >>+ * ATAPI packet commands. > >>+ */ > >>+#define ATAPI_FORMAT_UNIT_CMD 0x04 > >>+#define ATAPI_INQUIRY_CMD 0x12 > > > > > >[snip] > > > >We already have the "full" list in cdrom.h (GPCMD_*), so lets just use > >that. After all, ATAPI_MODE_SELECT10_CMD _is_ the same as the SCSI > >variant (and I think the _CMD post fixing is silly, anyone familiar with > >this is going to know what ATAPI_WRITE10 means just fine) > > > >Same for request_sense, that is already generalized in cdrom.h as well. > > I wonder what FreeBSD is using here? I see no need for invention at > this place. The invention would be adding the ATAPI_* commands, Linux has used the GPCMD_ convention for quite some time now. -- Jens Axboe