From: Jens Axboe <axboe@suse.de>
To: Martin Dalecki <dalecki@evision-ventures.com>
Cc: David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org
Subject: Re: IDE booting problems with 2.5.23
Date: Thu, 20 Jun 2002 12:35:32 +0200 [thread overview]
Message-ID: <20020620103532.GA812@suse.de> (raw)
In-Reply-To: <3D11A6BB.8030705@evision-ventures.com>
On Thu, Jun 20 2002, Martin Dalecki wrote:
> BTW> Jens did you notice that the IDE_DMA flag is a "read only"
> flag? I see basically only TQC code checking it. I would
> like to replace the drive->waiting_for_dma flag field by the
> proper usage of the IDE_DMA bit. Any way this could bite TCQ code?
> The checks there appear to be only sanity checks anyway.
At first I did just add them as sanity checks, but later on I had the
same thought myself (get rid of drive->waiting_for_dma). So go ahead
with that.
BTW, I see you renamed the flags to channel->active. I think that's a
bit misleading, can't you just call it ->state or ->flags (or
->state_flags? :-)
--
Jens Axboe
next prev parent reply other threads:[~2002-06-20 10:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-20 9:46 IDE booting problems with 2.5.23 David Howells
2002-06-20 9:56 ` Martin Dalecki
2002-06-20 10:35 ` Jens Axboe [this message]
2002-06-20 10:58 ` Martin Dalecki
2002-06-20 11:05 ` Jens Axboe
2002-06-20 11:22 ` Martin Dalecki
2002-06-20 10:51 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020620103532.GA812@suse.de \
--to=axboe@suse.de \
--cc=dalecki@evision-ventures.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox