From: Dave Jones <davej@suse.de>
To: Nicolas Aspert <Nicolas.Aspert@epfl.ch>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] Split up agpgart into per implementation files.
Date: Thu, 20 Jun 2002 16:06:12 +0200 [thread overview]
Message-ID: <20020620160612.I29373@suse.de> (raw)
In-Reply-To: <3D11CF69.3030103@epfl.ch>; from Nicolas.Aspert@epfl.ch on Thu, Jun 20, 2002 at 02:49:45PM +0200
On Thu, Jun 20, 2002 at 02:49:45PM +0200, Nicolas Aspert wrote:
> Definitely a good idea !
> The code is much easier to read.
Exactly. It also becomes a little easier to slot in support
for new vendors, than navigating a 120kb .c file.
> For those interested in trying this with 2.4, here is an adaptation of
> the patch for 2.4.19-pre10-ac2 . I did not include neither the changes
> made in 2.5.23 (at least they should not be here), nor the intel 460
> stuff (not present in 2.4).
Thanks for doing this.. I goofed the Makefile, and it doesn't build
correctly as modules under 2.5. Fixed one is at http://www.codemonkey.org.uk/Makefile
Just drop it into drivers/char/agp/ after applying my patch.
Due to build system differences, I'm not sure if your 2.4 patch also
suffers the same problem..
Oh, and agp.h has the definition of PFX below code which uses it,
and should be moved around..
Dave
--
| Dave Jones. http://www.codemonkey.org.uk
| SuSE Labs
next prev parent reply other threads:[~2002-06-20 14:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <fa.ep8m4pv.1gkki2v@ifi.uio.no>
2002-06-20 12:49 ` [PATCH] Split up agpgart into per implementation files Nicolas Aspert
2002-06-20 14:06 ` Dave Jones [this message]
2002-06-20 14:32 ` Nicolas Aspert
2002-06-19 16:19 Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020620160612.I29373@suse.de \
--to=davej@suse.de \
--cc=Nicolas.Aspert@epfl.ch \
--cc=dri-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox