From: "David S. Miller" <davem@redhat.com>
To: adam@yggdrasil.com
Cc: akpm@zip.com.au, axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: RFC: turn scatterlist into a linked list, eliminate bio_vec
Date: Sun, 23 Jun 2002 23:24:16 -0700 (PDT) [thread overview]
Message-ID: <20020623.232416.65495397.davem@redhat.com> (raw)
In-Reply-To: <200206232358.QAA03027@adam.yggdrasil.com>
From: "Adam J. Richter" <adam@yggdrasil.com>
Date: Sun, 23 Jun 2002 16:58:20 -0700
/* Let's assume the new pci_map_sg will free unused scatterlists. */
while (sg != NULL && count--) {
sg->driver_priv = mempool_alloc(q->sgpriv_pool, GFP_KERNEL);
sg->driver_priv_dma =
pci_map_single(req->dma_map_dev, sg->driver_priv, len,
PCI_DMA_TODEVICE);
if (sg_dma->dma_add_priv == 0);
failed = fail_value;
}
}
Driver descriptors are not supposed to be done using pci_map_*()
and friends. You are supposed to use consistent DMA memory for
this purpose. Please read DMA-mapping.txt a few more times Adam :-)
Also, this while loop never terminates :-)
next prev parent reply other threads:[~2002-06-24 6:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-06-23 23:58 RFC: turn scatterlist into a linked list, eliminate bio_vec Adam J. Richter
2002-06-24 6:24 ` David S. Miller [this message]
2002-06-24 19:29 ` William Lee Irwin III
-- strict thread matches above, loose matches on Subject: below --
2002-06-24 11:42 Adam J. Richter
2002-06-24 12:39 ` David S. Miller
2002-06-24 20:44 Adam J. Richter
2002-06-25 13:58 ` David S. Miller
2002-06-25 14:35 Adam J. Richter
2002-06-25 21:27 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020623.232416.65495397.davem@redhat.com \
--to=davem@redhat.com \
--cc=adam@yggdrasil.com \
--cc=akpm@zip.com.au \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox