Re: [PATCH/RFC 2.4.19-rc1] Fix dependancies on keybdev.o

Brad Hards
2002-06-26T21:01:21Z

On Thu, 27 Jun 2002 00:46, Tom Rini wrote:
> On Wed, Jun 26, 2002 at 12:36:24PM +1000, Brad Hards wrote:
> > 2. Move keyboard handling code to input subsystem
>
> I think that will work out the best. How's the attached look? It moves
> drivers/input/Config.in inside of drivers/char/Config.in and then fixes
> arches which had both. (Lightly tested from xconfig[1] for all arches
> which got changed).
I'm opposed to further junk going into drivers/char. It is already an
incomprehensible mess of unrelated code.

> > 3. Do wholesale backport of input subsystem from 2.5
>
> Not really an option (and 2.5 has this problem anyhow) since it's so
> invasive, once it's done.
Concur with the invasiveness angle.

Actually, I've got another idea, based on some stuff that I've been working on
for the ACPI "its not just power management" issue.

If you need to set something in drivers/input (per your original patch) that
depends on things that are set in drivers/char (or drivers/usb, anything that
comes later), then split the Config.in into two sections. One section
contains the normal Config.in user-selectable options, and a second
drivers/input/Config-post.in, that is sourced in at the end of
arch/foo/config.in and contains only automated Config.in dependancies (ie
define_bool) but no user selectable options.

Does this make sense? If not, I'll try for a patch that shows it later this
morning.

Brad
--
http://conf.linux.org.au. 22-25Jan2003. Perth, Australia. Birds in Black.