Re: [PATCH/RFC 2.4.19-rc1] Fix dependancies on keybdev.o

Tom Rini
2002-06-26T21:23:16Z

On Thu, Jun 27, 2002 at 06:58:04AM +1000, Brad Hards wrote:
> On Thu, 27 Jun 2002 00:46, Tom Rini wrote:
> > On Wed, Jun 26, 2002 at 12:36:24PM +1000, Brad Hards wrote:
> > > 2. Move keyboard handling code to input subsystem
> >
> > I think that will work out the best. How's the attached look? It moves
> > drivers/input/Config.in inside of drivers/char/Config.in and then fixes
> > arches which had both. (Lightly tested from xconfig[1] for all arches
> > which got changed).
>
> I'm opposed to further junk going into drivers/char. It is already an
> incomprehensible mess of unrelated code.

drivers/char/Config.in isn't too bad right now. If you skip over the
horrific mess that is serial support, anyhow. Perhaps moving some of
the arch-specific questions out to arch/$(ARCH)/config.in

> Actually, I've got another idea, based on some stuff that I've been working on
> for the ACPI "its not just power management" issue.
>
> If you need to set something in drivers/input (per your original patch) that
> depends on things that are set in drivers/char (or drivers/usb, anything that
> comes later), then split the Config.in into two sections. One section
> contains the normal Config.in user-selectable options, and a second
> drivers/input/Config-post.in, that is sourced in at the end of
> arch/foo/config.in and contains only automated Config.in dependancies (ie
> define_bool) but no user selectable options.
>
> Does this make sense? If not, I'll try for a patch that shows it later this
> morning.

I don't think this makes sense for input however, unless we kill off
drivers/input/Config.in (and for sh/m68k/sparc64 just paste the lines
in) and merge it into drivers/char/Config.in (CONFIG_INPUT,
CONFIG_INPUT_{KEYB,MOUSE,EV}DEV) and drivers/char/joystick/Config.in
(CONFIG_INPUT_JOYSTICK). I wouldn't be opposed to doing that...
And for USB (CONFIG_INPUT'ed) joysticks we aren't any worse off, and
perhaps we could even move those into a USB menu.