public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>, linux-kernel@vger.kernel.org
Subject: Re: 2.4.19-rc1 broke OSF binaries on alpha
Date: Sun, 30 Jun 2002 03:50:58 +0400	[thread overview]
Message-ID: <20020630035058.A884@localhost.park.msu.ru> (raw)
In-Reply-To: <E17O7yk-0007w5-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Sat, Jun 29, 2002 at 03:28:50AM +0100

On Sat, Jun 29, 2002 at 03:28:50AM +0100, Alan Cox wrote:
> Please back it back in. The bug is the Alpha port. Alpha needs its own OSF
> readv/writev entry point which masks the top bits.

Ouch. The new entry point just because of this?!
Marcelo, if you're going to back in that patch, please apply
the following on the top of it.

Ivan.

--- linux/fs/read_write.c.ac	Fri Jun 28 11:52:59 2002
+++ linux/fs/read_write.c	Sun Jun 30 03:21:52 2002
@@ -260,7 +260,15 @@ static ssize_t do_readv_writev(int type,
 	ret = -EINVAL;
 	for (i = 0 ; i < count ; i++) {
 		ssize_t tmp = tot_len;
+#ifdef	__alpha__
+		/* Current versions of Tru64 unix are SuS compliant.
+		   Unfortunately, we have to use the binaries (namely
+		   Netscape and Acrobat Reader) compiled vs. older
+		   versions of OSF/1, where iov_len was a 32 bit integer. */
+		ssize_t len = (int) iov[i].iov_len;
+#else
 		ssize_t len = (ssize_t) iov[i].iov_len;
+#endif
 		if (len < 0)	/* size_t not fitting an ssize_t .. */
 			goto out;
 		tot_len += len;

  reply	other threads:[~2002-06-29 23:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-28 10:54 2.4.19-rc1 broke OSF binaries on alpha Ivan Kokshaysky
2002-06-28 20:31 ` Marcelo Tosatti
2002-06-29  2:28   ` Alan Cox
2002-06-29 23:50     ` Ivan Kokshaysky [this message]
2002-07-01  7:54       ` Kurt Garloff
2002-07-01 16:17         ` Jeff Garzik
2002-07-01 13:03       ` jlnance
2002-07-01 14:02         ` Ivan Kokshaysky
2002-07-01 19:40           ` Måns Rullgård
2002-07-02 15:05             ` Ivan Kokshaysky
2002-07-02 23:13               ` Richard Henderson
2002-07-03  0:31                 ` Ivan Kokshaysky
2002-06-29  2:26 ` Alan Cox
2002-06-29 22:45   ` Ivan Kokshaysky
2002-07-02 20:56     ` Marcelo Tosatti
  -- strict thread matches above, loose matches on Subject: below --
2002-06-29  4:39 Chris Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020630035058.A884@localhost.park.msu.ru \
    --to=ink@jurassic.park.msu.ru \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox