public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] agpgart splitup and cleanup for 2.5.25
Date: Thu, 11 Jul 2002 16:02:23 -0700	[thread overview]
Message-ID: <20020711230222.GA5143@kroah.com> (raw)

So there I was, trying to remove pci_find_device() and pci_find_class()
from the 2.5 kernel (it's an old depreciated api, so don't start
complaining...) when I ran across the agpgart code which uses
pci_find_class().  I realized I'd have to fix this driver to use the
"new" pci api if I had a chance of getting rid of pci_find_class().
Dave Jones had previously split up this driver into some very nice
logical parts, and it has been living successfully in his tree for a
while now.

So I took that patch, and cleaned it up a bit more (removed some
unneeded typedefs, whitespace changes, moved the Config.in and
Configure.help stuff to the drivers/char/agp directory) and ported the
driver to the pci_register_module() api.  It seems to work for me, so I
would appreciate it if other people tested it out before I sent it on to
Linus for inclusion in the main 2.5 tree.

It can be found at:
	http://www.kernel.org/pub/linux/kernel/people/gregkh/misc/agpgart-2.5.25.patch.bz2

Here's the diffstat output of it:
 drivers/char/Config.help             |   87 
 drivers/char/Config.in               |   15 
 drivers/char/agp/Config.help         |   88 
 drivers/char/agp/Config.in           |   14 
 drivers/char/agp/Makefile            |   13 
 drivers/char/agp/agp.h               |  348 +-
 drivers/char/agp/agpgart_be-ali.c    |  265 ++
 drivers/char/agp/agpgart_be-amd.c    |  408 +++
 drivers/char/agp/agpgart_be-hp.c     |  394 +++
 drivers/char/agp/agpgart_be-i460.c   |  595 ++++
 drivers/char/agp/agpgart_be-i810.c   |  594 ++++
 drivers/char/agp/agpgart_be-i8x0.c   |  720 +++++
 drivers/char/agp/agpgart_be-sis.c    |  142 +
 drivers/char/agp/agpgart_be-sworks.c |  626 +++++
 drivers/char/agp/agpgart_be-via.c    |  151 +
 drivers/char/agp/agpgart_be.c        | 4368 +++--------------------------------
 drivers/char/agp/agpgart_fe.c        |   15 
 include/linux/agp_backend.h          |    6 
 include/linux/agpgart.h              |   10 
 19 files changed, 4682 insertions(+), 4177 deletions(-)

thanks,

greg k-h

             reply	other threads:[~2002-07-11 22:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-11 23:02 Greg KH [this message]
2002-07-11 23:18 ` [PATCH] agpgart splitup and cleanup for 2.5.25 Greg KH
2002-07-12 12:56   ` Dave Jones
2002-07-12 22:17 ` Greg KH
2002-07-15  8:17   ` Geert Uytterhoeven
2002-07-16  0:10     ` Greg KH
2002-07-15  5:38 ` Linus Torvalds
2002-07-15  8:46   ` Dave Jones
2002-07-15 16:42     ` Jeff Garzik
2002-07-15 16:45       ` Dave Jones
2002-07-15 18:23         ` Linus Torvalds
2002-07-28 14:06 ` Tommy Faasen
2002-07-28 19:00   ` Greg KH
2002-07-28 19:09     ` Dave Jones
2002-07-28 19:23     ` root

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020711230222.GA5143@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox