From: Andreas Dilger <adilger@clusterfs.com>
To: Thunder from the hill <thunder@ngforever.de>
Cc: Dawson Engler <engler@csl.Stanford.EDU>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
mc@cs.Stanford.EDU
Subject: Re: [CHECKER] 56 potential lock/unlock bugs in 2.5.8
Date: Thu, 11 Jul 2002 17:32:26 -0600 [thread overview]
Message-ID: <20020711233226.GC8738@clusterfs.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0207111711530.26269-100000@hawkeye.luckynet.adm>
On Jul 11, 2002 17:14 -0600, Thunder from the hill wrote:
> --- fs/hpfs/dir.c 19 Jun 2002 02:11:50 -0000 1.1.1.1
> +++ fs/hpfs/dir.c 11 Jul 2002 22:12:53 -0000
> @@ -211,7 +211,9 @@ struct dentry *hpfs_lookup(struct inode
>
> lock_kernel();
> if ((err = hpfs_chk_name((char *)name, &len))) {
> - if (err == -ENAMETOOLONG) return ERR_PTR(-ENAMETOOLONG);
> + if (err == -ENAMETOOLONG) {
> + return ERR_PTR(-ENAMETOOLONG);
> + }
> goto end_add;
> }
So, how does adding braces and a linefeed fix the locking problem here?
;-)
Cheers, Andreas
--
Andreas Dilger
http://www-mddsp.enel.ucalgary.ca/People/adilger/
http://sourceforge.net/projects/ext2resize/
next prev parent reply other threads:[~2002-07-11 23:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-11 21:35 [CHECKER] 56 potential lock/unlock bugs in 2.5.8 Dawson Engler
2002-07-11 21:54 ` Thunder from the hill
2002-07-11 22:21 ` Oliver Neukum
2002-07-11 23:14 ` Thunder from the hill
2002-07-11 23:32 ` Andreas Dilger [this message]
2002-07-11 23:45 ` Thunder from the hill
2002-07-11 23:41 ` Chris Wright
2002-07-12 0:21 ` Andrew Morton
2002-07-12 1:44 ` Arnaldo Carvalho de Melo
2002-07-12 17:40 ` Roman Zippel
2002-07-12 17:53 ` Thunder from the hill
2002-07-12 18:37 ` Roman Zippel
2002-07-12 18:05 ` Dave Jones
2002-07-12 18:32 ` Roman Zippel
2002-07-12 18:37 ` Dave Jones
2002-07-12 20:34 ` Roman Zippel
2002-07-12 20:48 ` Dave Jones
2002-07-12 21:30 ` Roman Zippel
2002-07-12 21:38 ` Dave Jones
2002-07-12 21:56 ` Roman Zippel
2002-07-12 22:14 ` Dave Jones
2002-07-12 22:34 ` Roman Zippel
2002-07-12 22:41 ` Dave Jones
2002-07-12 13:17 ` David Woodhouse
2002-07-12 13:26 ` Thunder from the hill
-- strict thread matches above, loose matches on Subject: below --
2002-07-11 22:32 Grover, Andrew
2002-07-11 23:26 ` Dawson Engler
[not found] <200207112135.OAA03801@csl.Stanford.EDU.suse.lists.linux.kernel>
2002-07-11 22:34 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020711233226.GC8738@clusterfs.com \
--to=adilger@clusterfs.com \
--cc=engler@csl.Stanford.EDU \
--cc=linux-kernel@vger.kernel.org \
--cc=mc@cs.Stanford.EDU \
--cc=thunder@ngforever.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox