public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Filip Van Raemdonck <filipvr@xs4all.be>
To: linux-kernel@vger.kernel.org
Cc: fischer@norbit.de, marcelo@conectiva.com.br
Subject: [PATCH] aha152x fix
Date: Tue, 16 Jul 2002 23:10:03 +0200	[thread overview]
Message-ID: <20020716231003.A488@lucretia.debian.net> (raw)

Hi,

I upgraded from 2.4.19-pre7 to -rc1 and this resulted in my aha152x card not
working anymore. (The error was "trying software interrupt, lost")

Below is a patch which makes it work again. Note that this is just reverting
a minimal part of the last applied patch to aha152x.c; so this may only be
fixing the symptom and not the problem.

Can somebody confirm if this is correct or not, and give some more insight
into this behaviour?


Regards,

Filip

--- aha152x.c.orig	Tue Jul 16 22:20:57 2002
+++ aha152x.c	Tue Jul 16 21:43:51 2002
@@ -1366,11 +1366,13 @@
 		}
 		HOSTDATA(shpnt)->swint = 0;
 
 		printk(KERN_INFO "aha152x%d: trying software interrupt, ", HOSTNO);
 		SETPORT(DMACNTRL0, SWINT|INTEN);
+		spin_unlock_irq (&io_request_lock);
 		mdelay(1000);
+		spin_lock_irq (&io_request_lock);
 		free_irq(shpnt->irq, shpnt);
 
 		if (!HOSTDATA(shpnt)->swint) {
 			if (TESTHI(DMASTAT, INTSTAT)) {
 				printk("lost.\n");

-- 
"Microsoft shouldn't be broken up.  It should be shut down."
	-- Phil Agre on the ILOVEYOU virus.

             reply	other threads:[~2002-07-16 21:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-16 21:10 Filip Van Raemdonck [this message]
2002-07-16 23:00 ` [PATCH] aha152x fix Alan Cox
2002-07-17  7:09   ` Filip Van Raemdonck
2002-07-17  8:02   ` Martin Diehl
2002-07-17 21:35     ` Filip Van Raemdonck
     [not found]       ` <20020718055204.GA10357@linux-buechse.de>
2002-07-18  7:42         ` Filip Van Raemdonck
2002-07-18 12:34         ` Martin Diehl
     [not found] <20020718222805.GA16641@linux-buechse.de>
2002-07-19 17:09 ` Martin Diehl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020716231003.A488@lucretia.debian.net \
    --to=filipvr@xs4all.be \
    --cc=fischer@norbit.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox