From: Werner Almesberger <wa@almesberger.net>
To: Anders Gustafsson <andersg@0x63.nu>
Cc: Russell King <rmk@arm.linux.org.uk>,
linux-kernel@vger.kernel.org, jsimmons@transvirtual.com
Subject: Re: [PATCH] CONFIG_MAGIC_SYSRQ without CONFIG_VT broken in 2.5.26
Date: Fri, 19 Jul 2002 08:52:39 -0300 [thread overview]
Message-ID: <20020719085239.F1424@almesberger.net> (raw)
In-Reply-To: <20020719105244.GB13706@h55p111.delphi.afb.lu.se>; from andersg@0x63.nu on Fri, Jul 19, 2002 at 12:52:44PM +0200
Anders Gustafsson wrote:
> Shouldn't that be something more like?
>
> +#ifdef CONFIG_VT
> /* r */ &sysrq_unraw_op,
> +#else
> +/* r */ NULL,
> +#endif
Argl, I'm an idiot. Yes, you're absolutely right. Corrected patch
below.
- Werner
------------------------------------ patch ------------------------------------
--- linux-2.5.26/drivers/char/sysrq.c.orig Fri Jul 19 08:37:18 2002
+++ linux-2.5.26/drivers/char/sysrq.c Fri Jul 19 08:37:53 2002
@@ -74,7 +74,6 @@
help_msg: "saK",
action_msg: "SAK",
};
-#endif
/* unraw sysrq handler */
@@ -91,6 +90,7 @@
help_msg: "unRaw",
action_msg: "Keyboard mode set to XLATE",
};
+#endif /* CONFIG_VT */
/* reboot sysrq handler */
@@ -371,7 +371,11 @@
as 'Off' at init time */
/* p */ &sysrq_showregs_op,
/* q */ NULL,
+#ifdef CONFIG_VT
/* r */ &sysrq_unraw_op,
+#else
+/* r */ NULL,
+#endif
/* s */ &sysrq_sync_op,
/* t */ &sysrq_showstate_op,
/* u */ &sysrq_mountro_op,
--
_________________________________________________________________________
/ Werner Almesberger, Buenos Aires, Argentina wa@almesberger.net /
/_http://icapeople.epfl.ch/almesber/_____________________________________/
next prev parent reply other threads:[~2002-07-19 11:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-19 1:06 [PATCH] CONFIG_MAGIC_SYSRQ without CONFIG_VT broken in 2.5.26 Werner Almesberger
2002-07-19 8:10 ` Russell King
2002-07-19 10:52 ` Anders Gustafsson
2002-07-19 11:52 ` Werner Almesberger [this message]
2002-07-19 18:05 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020719085239.F1424@almesberger.net \
--to=wa@almesberger.net \
--cc=andersg@0x63.nu \
--cc=jsimmons@transvirtual.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox