From: Russell King <rmk@arm.linux.org.uk>
To: Werner Almesberger <wa@almesberger.net>
Cc: linux-kernel@vger.kernel.org, jsimmons@transvirtual.com
Subject: Re: [PATCH] CONFIG_MAGIC_SYSRQ without CONFIG_VT broken in 2.5.26
Date: Fri, 19 Jul 2002 09:10:17 +0100 [thread overview]
Message-ID: <20020719091017.A28569@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20020718220635.A15794@almesberger.net>; from wa@almesberger.net on Thu, Jul 18, 2002 at 10:06:35PM -0300
On Thu, Jul 18, 2002 at 10:06:35PM -0300, Werner Almesberger wrote:
> 2.5.26 fails with missing symbols fg_console and kbd_table if
> enabling Magic SysRq but disabling virtual terminals. The
> trivial patch below fixes this.
I posted a fix for this on July 17th. However, yours looks better.
James?
> ------------------------------------ patch ------------------------------------
--- linux-2.5.26/drivers/char/sysrq.c.orig Thu Jul 18 12:55:09 2002
+++ linux-2.5.26/drivers/char/sysrq.c Thu Jul 18 12:55:15 2002
@@ -74,7 +74,6 @@
help_msg: "saK",
action_msg: "SAK",
};
-#endif
/* unraw sysrq handler */
@@ -91,6 +90,7 @@
help_msg: "unRaw",
action_msg: "Keyboard mode set to XLATE",
};
+#endif /* CONFIG_VT */
/* reboot sysrq handler */
@@ -371,7 +371,9 @@
as 'Off' at init time */
/* p */ &sysrq_showregs_op,
/* q */ NULL,
+#ifdef CONFIG_VT
/* r */ &sysrq_unraw_op,
+#endif
/* s */ &sysrq_sync_op,
/* t */ &sysrq_showstate_op,
/* u */ &sysrq_mountro_op,
> --
> _________________________________________________________________________
> / Werner Almesberger, Buenos Aires, Argentina wa@almesberger.net /
> /_http://icapeople.epfl.ch/almesber/_____________________________________/
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-07-19 8:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-19 1:06 [PATCH] CONFIG_MAGIC_SYSRQ without CONFIG_VT broken in 2.5.26 Werner Almesberger
2002-07-19 8:10 ` Russell King [this message]
2002-07-19 10:52 ` Anders Gustafsson
2002-07-19 11:52 ` Werner Almesberger
2002-07-19 18:05 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020719091017.A28569@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=jsimmons@transvirtual.com \
--cc=linux-kernel@vger.kernel.org \
--cc=wa@almesberger.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox