Re: [patch] cli()/sti() cleanup, 2.5.27-A2

Ingo Molnar
2002-07-22T13:42:03Z

On Mon, 22 Jul 2002, Christoph Hellwig wrote:

> void irq_off(void);
> void irq_on(void);
>
> flags_t irq_save();
> void irq_restore(flags_t);

i'm not so sure about flags_t. 'unsigned long' worked pretty well so far,
and i do not see the need for a more complex (or more opaque) irqflags
type. It's not that we confuse flags with some other flag all that
frequently that would necessiate some structure-based more abstract
protection of these variables.

(wrt. inline functions, every architecture is free to define them as
inline functions as they see fit.)

Ingo