Re: [patch] "big IRQ lock" removal, 2.5.27-A1

Ingo Molnar
2002-07-21T19:12:54Z

On Sun, 21 Jul 2002, Linus Torvalds wrote:

> This seems to have tons of stuff which makes it compile, but which is
> just broken. Randomly changing "cli()" to "__cli()" apparently just to
> make it compile, with no warning that its now buggy.

indeed ...

fixed these, and have categorized every change whether it's safe,
known-unsafe or unknown-effect, and commented the latter two.

i also removed the save_flags() and restore_flags() macros on SMP which
were left there by accident.

new patch is at:

http://redhat.com/~mingo/remove-irqlock-patches/remove-irqlock-2.5.27-A3

(there's one more open bug, i can now see the 'exited with preempt_count
1' messages.)

Ingo