Re: [patch] cli()/sti() cleanup, 2.5.27-A2

Marcin Dalecki
2002-07-22T14:03:04Z

Ingo Molnar wrote:
> On Mon, 22 Jul 2002, Christoph Hellwig wrote:
>
>
>>yupp, you're right. could you take the prototype changes anyway?
>
>
> i'm hesitant for a number of reasons. Eg. irq_save_off(flags) has to be a
> macro, otherwise we move the assignment into the irqs-off section.
> Compare:
>
> flags = irq_save_off();
>
> with:
> irq_flags_off(flags);
>
> sure, it could be written as:
>
> flags = irq_save();
> irq_off();
>
> but then again the macro form is more compact.

By 2 characters. And hiding the side-effect. We don't have the notion of
var argument passing like in pascal or C++ here.