Re: [patch] cli()/sti() cleanup, 2.5.27-A2

Ingo Molnar
2002-07-22T13:48:55Z

On Mon, 22 Jul 2002, Russell King wrote:

> > i'm not so sure about flags_t. 'unsigned long' worked pretty well so far,
> > and i do not see the need for a more complex (or more opaque) irqflags
> > type.
>
> A feature request then. Type checking. Too many people try to stuff
> the value into an int or signed long.

the next portion of the quote deals with this:

> > It's not that we confuse flags with some other flag all that
> > frequently that would necessiate some structure-based more abstract
> > protection of these variables.

are you sure type-checking is really needed? Sure people can mess up the
flags variable, but 64-bit archs could do a sizeof at compile-time.

Ingo