Re: [patch] cli()/sti() cleanup, 2.5.27-A2

Ingo Molnar
2002-07-22T14:05:25Z

On Mon, 22 Jul 2002, Marcin Dalecki wrote:

> > i'm hesitant for a number of reasons. Eg. irq_save_off(flags) has to be a
> > macro, otherwise we move the assignment into the irqs-off section.
> > Compare:
> >
> > flags = irq_save_off();
> >
> > with:
> > irq_flags_off(flags);
> >
> > sure, it could be written as:
> >
> > flags = irq_save();
> > irq_off();
> >
> > but then again the macro form is more compact.
>
> By 2 characters. [...]

and a full line ...

> [...] And hiding the side-effect. We don't have the notion of var
> argument passing like in pascal or C++ here.

well, it's a well-known side effect on the other hand.

Ingo