From: Christoph Hellwig <hch@lst.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Russell King <rmk@arm.linux.org.uk>,
Linus Torvalds <torvalds@transmeta.com>,
Christoph Hellwig <hch@lst.de>, Robert Love <rml@tech9.net>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] cli()/sti() cleanup, 2.5.27-A2
Date: Mon, 22 Jul 2002 15:20:56 +0200 [thread overview]
Message-ID: <20020722152056.A18619@lst.de> (raw)
In-Reply-To: <Pine.LNX.4.44.0207221248250.4519-100000@localhost.localdomain>; from mingo@elte.hu on Mon, Jul 22, 2002 at 03:01:48PM +0200
On Mon, Jul 22, 2002 at 03:01:48PM +0200, Ingo Molnar wrote:
> So what i did in my tree was to introduce the following 5 core means of
> manipulating the local interrupt flags:
>
> irq_off()
> irq_on()
> irq_save(flags)
> irq_save_off(flags)
> irq_restore(flags)
I'd prefer the following:
void irq_off(void);
void irq_on(void);
flags_t irq_save(); /* the old irq_save_off() */
void irq_restore(flags_t);
void __irq_save(void); /* without saveing */
rational: proper function-like API (should be inlines), irq save
without disableing is very uncommon, better make the API symmetric.
next prev parent reply other threads:[~2002-07-22 13:18 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-21 18:50 [patch] "big IRQ lock" removal, 2.5.27-A1 Ingo Molnar
2002-07-21 19:00 ` Linus Torvalds
2002-07-21 19:14 ` Ingo Molnar
2002-07-21 19:24 ` Ingo Molnar
2002-07-21 20:41 ` [patch] "big IRQ lock" removal, 2.5.27-A5 Ingo Molnar
2002-07-21 20:50 ` Ingo Molnar
2002-07-21 20:59 ` [patch] "big IRQ lock" removal, 2.5.27-A7 Ingo Molnar
2002-07-21 21:26 ` [patch] "big IRQ lock" removal, 2.5.27-A9 Ingo Molnar
2002-07-21 21:46 ` Christoph Hellwig
2002-07-21 21:56 ` Ingo Molnar
2002-07-21 23:20 ` Linus Torvalds
2002-07-22 0:31 ` Ingo Molnar
2002-07-22 0:40 ` Russell King
2002-07-22 0:55 ` Robert Love
2002-07-22 13:01 ` [patch] cli()/sti() cleanup, 2.5.27-A2 Ingo Molnar
2002-07-22 13:20 ` Christoph Hellwig [this message]
2002-07-22 13:23 ` Ingo Molnar
2002-07-22 13:26 ` Christoph Hellwig
2002-07-22 13:26 ` Ingo Molnar
2002-07-22 13:30 ` Christoph Hellwig
2002-07-22 13:36 ` [patch] remove-irqlock-2.5.27-D7 Ingo Molnar
2002-07-22 13:38 ` [patch] cli()/sti() cleanup, 2.5.27-A2 Ingo Molnar
2002-07-22 13:43 ` Christoph Hellwig
2002-07-22 13:49 ` Ingo Molnar
2002-07-22 14:00 ` Marcin Dalecki
2002-07-22 14:07 ` Ingo Molnar
2002-07-22 13:24 ` Christoph Hellwig
2002-07-22 13:43 ` Ingo Molnar
2002-07-22 13:46 ` Russell King
2002-07-22 13:49 ` Ingo Molnar
2002-07-30 9:17 ` Pavel Machek
2002-07-22 13:57 ` Marcin Dalecki
2002-07-22 14:05 ` Ingo Molnar
2002-07-22 14:27 ` Russell King
2002-07-22 14:28 ` Ingo Molnar
2002-07-22 13:46 ` Christoph Hellwig
2002-07-22 13:52 ` Ingo Molnar
2002-07-22 17:13 ` Linus Torvalds
2002-07-22 18:01 ` Ingo Molnar
2002-07-23 6:48 ` Zwane Mwaikambo
2002-07-22 1:00 ` [patch] "big IRQ lock" removal, 2.5.27-A9 Robert Love
2002-07-21 23:43 ` Russell King
2002-07-21 23:44 ` Ingo Molnar
2002-07-21 23:47 ` Russell King
2002-07-21 23:58 ` Ingo Molnar
2002-07-22 1:04 ` Alan Cox
2002-07-21 23:52 ` Ingo Molnar
2002-07-21 22:17 ` [patch] "big IRQ lock" removal, 2.5.27-A5 Alan Cox
2002-07-21 19:38 ` [patch] "big IRQ lock" removal, 2.5.27-A1 Robert Love
2002-07-21 22:19 ` Ingo Molnar
2002-07-21 23:55 ` Robert Love
2002-07-21 19:58 ` Russell King
2002-07-21 20:09 ` Ingo Molnar
2002-07-21 20:42 ` Russell King
2002-07-21 21:09 ` Ingo Molnar
2002-07-21 21:18 ` Russell King
2002-07-21 21:20 ` Ingo Molnar
2002-07-21 21:29 ` Ingo Molnar
2002-07-21 21:39 ` Ingo Molnar
2002-07-21 23:23 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020722152056.A18619@lst.de \
--to=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rmk@arm.linux.org.uk \
--cc=rml@tech9.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox