From: "David S. Miller" <davem@redhat.com>
To: trond.myklebust@fys.uio.no
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.5.27 fix potential spinlocking race.
Date: Tue, 23 Jul 2002 19:09:03 -0700 (PDT) [thread overview]
Message-ID: <20020723.190903.50511601.davem@redhat.com> (raw)
In-Reply-To: <15677.48609.62376.119269@charged.uio.no>
In case of socket transmission errors etc. kfree_skb(), and hence
xprt_write_space() can potentially get called outside of a bh-safe
context.
kfree_skb must occur within a BH context or better context.
When HW interrupt handlers free packets they use kfree_skb_irq() which
schedules a software interrupt to really perform the kfree_skb work.
Therefore kfree_skb must always be invoked in BH or better context.
I think we need to reevaluate this situation before we apply this
patch :-)
next prev parent reply other threads:[~2002-07-24 2:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-23 20:34 [PATCH] 2.5.27 fix potential spinlocking race Trond Myklebust
2002-07-24 2:09 ` David S. Miller [this message]
2002-07-24 2:24 ` Linus Torvalds
2002-07-24 13:05 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020723.190903.50511601.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox