public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* cpqarray broken since 2.5.19
@ 2002-07-21 15:28 Adam Kropelin
  2002-07-24 13:39 ` Jens Axboe
  0 siblings, 1 reply; 16+ messages in thread
From: Adam Kropelin @ 2002-07-21 15:28 UTC (permalink / raw)
  To: linux-kernel; +Cc: axboe

The cpqarray driver seems to have been broken around 2.5.19 with the
blk_start_queue/blk_stop_queue changes. As-is, cpqarray deadlocks the entire
system when it tries to do partition detection. The bits from the 2.5.19 patch
which seem to relate are:

> @@ -916,6 +915,7 @@
>       goto queue_next;
>
>  startio:
> +     blk_stop_queue(q);
>       start_io(h);
>  }
>
> @@ -1066,8 +1066,8 @@
>       /*
>        * See if we can queue up some more IO
>        */
> -     do_ida_request(BLK_DEFAULT_QUEUE(MAJOR_NR + h->ctlr));
>       spin_unlock_irqrestore(IDA_LOCK(h->ctlr), flags);
> +     blk_start_queue(BLK_DEFAULT_QUEUE(MAJOR_NR + h->ctlr));
>  }
>
>  /*

Simply reverting these changes allows the driver to successfully do partition
detect, but it quickly hangs if any significant amount of I/O is attempted. The
hang in this case seems to just affect processes trying to do I/O on the array;
it is not a whole-system-deadlock.

Test machine is SMP ppro.

--Adam


^ permalink raw reply	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2002-07-26  0:27 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2002-07-21 15:28 cpqarray broken since 2.5.19 Adam Kropelin
2002-07-24 13:39 ` Jens Axboe
2002-07-24 14:07   ` Bartlomiej Zolnierkiewicz
2002-07-24 14:09     ` Jens Axboe
2002-07-24 14:11     ` Marcin Dalecki
2002-07-24 14:19       ` Jens Axboe
2002-07-24 14:41         ` Bartlomiej Zolnierkiewicz
2002-07-24 14:44           ` Jens Axboe
2002-07-24 14:46           ` Marcin Dalecki
2002-07-24 15:15             ` Bartlomiej Zolnierkiewicz
2002-07-24 14:21       ` Bartlomiej Zolnierkiewicz
2002-07-24 14:27         ` Marcin Dalecki
2002-07-24 14:45           ` Bartlomiej Zolnierkiewicz
2002-07-25  0:32   ` Adam Kropelin
2002-07-25 10:39     ` Jens Axboe
2002-07-26  0:30       ` Adam Kropelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox