From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andre Hedrick <andre@linux-ide.org>, <martin@dalecki.de>,
Vojtech Pavlik <vojtech@suse.cz>,
William Lee Irwin III <wli@holomorphy.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [RFC/CFT] cmd640 irqlocking fixes
Date: Thu, 25 Jul 2002 15:39:18 +0200 [thread overview]
Message-ID: <20020725133918.37@192.168.4.1> (raw)
In-Reply-To: <1027602528.9488.68.camel@irongate.swansea.linux.org.uk>
>Martin this patch should do the job. It uses the correct pci_config_lock
>and it also adds the 2.4 probe safety checks for deciding which pci
>modes to use.
Hrm... pci_config_lock is specific to arch/i386 it seems (and is even
a static in 2.4.19rc3). That is no good as this isn't the only
driver to do config access from interrupts, so at least PPC is
broken in this regard.
Wouldn't it make sense to generalize it and implement it on all archs ?
(That is move extern declaration of it to linux/pci.h, definition to
drivers/pci/pci.c, and so on...)
I'd rather have a per-host lock, but on the other hand, the host bus
mecanism is still quite arch-specific, thus making difficult to use
a per-host lock in drivers, at least in 2.4
Ben.
next prev parent reply other threads:[~2002-07-25 13:36 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-24 22:58 [RFC/CFT] cmd640 irqlocking fixes William Lee Irwin III
2002-07-24 23:16 ` William Lee Irwin III
2002-07-25 1:05 ` Alan Cox
2002-07-25 7:54 ` Vojtech Pavlik
2002-07-25 8:28 ` Marcin Dalecki
2002-07-25 8:55 ` Vojtech Pavlik
2002-07-25 8:56 ` Marcin Dalecki
2002-07-25 10:24 ` Alan Cox
2002-07-25 10:37 ` Marcin Dalecki
2002-07-25 10:51 ` Andre Hedrick
2002-07-25 12:52 ` Alan Cox
2002-07-25 12:05 ` Andre Hedrick
2002-07-25 13:08 ` Alan Cox
2002-07-25 11:53 ` Marcin Dalecki
2002-07-25 12:30 ` Andre Hedrick
2002-07-25 14:33 ` Alan Cox
2002-07-25 13:39 ` Benjamin Herrenschmidt [this message]
2002-07-25 14:18 ` PCI config locking (WAS Re: [RFC/CFT] cmd640 irqlocking fixes)2 Benjamin Herrenschmidt
2002-07-25 15:45 ` Alan Cox
2002-07-25 14:40 ` benh
2002-07-25 16:10 ` Alan Cox
2002-07-25 23:04 ` Alan Cox
2002-07-25 14:48 ` Dave Jones
2002-07-25 15:44 ` Thunder from the hill
2002-07-29 7:13 ` David S. Miller
2002-07-26 0:41 ` Marcin Dalecki
2002-07-26 0:15 ` [RFC/CFT] cmd640 irqlocking fixes Albert D. Cahalan
2002-07-25 10:22 ` Alan Cox
2002-07-25 8:01 ` Marcin Dalecki
-- strict thread matches above, loose matches on Subject: below --
2002-07-25 12:50 Petr Vandrovec
2002-07-25 14:34 ` Alan Cox
2002-07-26 2:15 ` Marcin Dalecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020725133918.37@192.168.4.1 \
--to=benh@kernel.crashing.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andre@linux-ide.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@dalecki.de \
--cc=vojtech@suse.cz \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox