Re: [PATCH] cheap lookup of symbol names on oops()

Andrea Arcangeli
2002-07-25T20:55:08Z

On Thu, Jul 25, 2002 at 02:27:16PM -0600, Cort Dougan wrote:
> None of the changes look like a problem. I'll absorb them and send another

the lack of <= was a bug, the buffer overflows on the stack with symbols
> 60 was a bug too even if less likely to trigger.

> patch. One that fixes Ben's criticisms of spurious whitespace, even :)
>
> Are you suggesting that it should print the start/end of the module in each
> trace in addition to the symbol names or instead of them?

Not the end, just the start, and not in addition, but only the start
address of each module without any symbol.

> I've found it valuable to have the EIP resolved. Even though the symbol
> name may not be perfect (only resolves exported names) it is valuable to
> see that the function crashed 0x1fe bytes after a given symbol name.

valuable for what? you need the system.map or the .o disassembly of the
module anyways to take advantage of such symbol. I don't find it useful.
Furthmore ksymoops will prefer to work with hex numbers rather than
doing the reverse lookup to the number and then resolving to the right
symbol (and not only ksymoops, me too while doing by hand and that's why
I prefer hex there)

One thing is if you have ksymall ala kdb and you can resolve to
something where you don't need the system.map to guess what happened,
but without the ksymall you need the system.map or vmlinux anyways.

Andrea