Re: [PATCH] cheap lookup of symbol names on oops()

Cort Dougan
2002-07-25T20:20:00Z

Nearly all of the code scattered through arch/ppc uses the Cort indention
style, it hasn't done any damage. I don't think a 50 line patch is going
to drag Linux down into the mudpits because of an extra \n. If the
indention is an issue it can be quickly changed when it's applied.

Aunt Tillie is, after all, a non-coder. She was just barely able to
configure the kernel thanks to CML2. If Penelope hadn't been helped out by
the creepy guy and the good looking guy she wouldn't even have started
emacs.

As for myself, I think 50 locking primitives are spurious but a couple
extra whitespace chars are just a minor issue :)

} It looks like she still has to ready the Documentation/CodingStyle. The
} space after the ( and before the ) are spurious, and thes { belongs on
} the same line as the if.