Re: [patch] cli()/sti() cleanup, 2.5.27-A2

Christoph Hellwig
2002-07-22T13:46:21Z

On Mon, Jul 22, 2002 at 03:43:50PM +0200, Ingo Molnar wrote:
> i'm not so sure about flags_t. 'unsigned long' worked pretty well so far,
> and i do not see the need for a more complex (or more opaque) irqflags
> type. It's not that we confuse flags with some other flag all that
> frequently that would necessiate some structure-based more abstract
> protection of these variables.

It's just that we don't really care what it is. But the type change
wasn't my main point, rather the returning of the flags value in
irq_save to allow implementing it as non-macro.