From: James Mayer <james@cobaltmountain.com>
To: linux-kernel@vger.kernel.org
Cc: Kai Engert <kai.engert@gmx.de>, Ani Joshi <ajoshi@unixbox.com>
Subject: Re: Sync bit bug in drivers/video/radeonfb.c ?
Date: Tue, 30 Jul 2002 08:33:09 -0600 [thread overview]
Message-ID: <20020730143309.GA21219@galileo> (raw)
In-Reply-To: <3D4689E5.5000504@gmx.de>
Hi Kai,
Oddly enough, if I apply this patch on my C1MV/M, I lose the upper
half of my uppermost line, and must use fbset -vsync low to fix it.
I determined the 1200x600 modedb entry using the existing radeonfb
driver, and it appears our hardware is exactly opposite on this issue.
Which C1M* do you have?
James
> --- bad/drivers/video/radeonfb.c Tue Jul 30 14:38:29 2002
> +++ good/drivers/video/radeonfb.c Tue Jul 30 14:39:10 2002
> @@ -2401,8 +2401,8 @@
> }
>
> sync = mode->sync;
> - h_sync_pol = sync & FB_SYNC_HOR_HIGH_ACT ? 0 : 1;
> - v_sync_pol = sync & FB_SYNC_VERT_HIGH_ACT ? 0 : 1;
> + h_sync_pol = sync & FB_SYNC_HOR_HIGH_ACT ? 1 : 0;
> + v_sync_pol = sync & FB_SYNC_VERT_HIGH_ACT ? 1 : 0;
>
> RTRACE("hStart = %d, hEnd = %d, hTotal = %d\n",
> hSyncStart, hSyncEnd, hTotal);
next prev parent reply other threads:[~2002-07-30 14:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-30 12:43 Sync bit bug in drivers/video/radeonfb.c ? Kai Engert
2002-07-30 14:33 ` James Mayer [this message]
2002-07-30 14:54 ` Kai Engert
2002-07-30 15:08 ` Russell King
2002-07-31 15:57 ` James Mayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020730143309.GA21219@galileo \
--to=james@cobaltmountain.com \
--cc=ajoshi@unixbox.com \
--cc=kai.engert@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox