Re: Sync bit bug in drivers/video/radeonfb.c ?

Kai Engert
2002-07-30T14:51:04Z

That's strange! I'm using a C1MGP, german version.

See http://www.kuix.de/sonyc1/lspci for lspci output.

However, if you apply the patch below, and you have to manually set it
to vsync low, I guess this means your on boot mode was set to high,
which is what is requested in modedb.c, and it sounds like the patch
below is correct. But we probably need more entries in modedb.c to
support all models of the C1M.

Kai

James Mayer wrote:
> Hi Kai,
>
> Oddly enough, if I apply this patch on my C1MV/M, I lose the upper
> half of my uppermost line, and must use fbset -vsync low to fix it.
>
> I determined the 1200x600 modedb entry using the existing radeonfb
> driver, and it appears our hardware is exactly opposite on this issue.
>
> Which C1M* do you have?
>
> James
>
>
>>--- bad/drivers/video/radeonfb.c Tue Jul 30 14:38:29 2002
>>+++ good/drivers/video/radeonfb.c Tue Jul 30 14:39:10 2002
>>@@ -2401,8 +2401,8 @@
>> }
>>
>> sync = mode->sync;
>>- h_sync_pol = sync & FB_SYNC_HOR_HIGH_ACT ? 0 : 1;
>>- v_sync_pol = sync & FB_SYNC_VERT_HIGH_ACT ? 0 : 1;
>>+ h_sync_pol = sync & FB_SYNC_HOR_HIGH_ACT ? 1 : 0;
>>+ v_sync_pol = sync & FB_SYNC_VERT_HIGH_ACT ? 1 : 0;
>>
>> RTRACE("hStart = %d, hEnd = %d, hTotal = %d\n",
>> hSyncStart, hSyncEnd, hTotal);