From: Ravikiran G Thirumalai <kiran@in.ibm.com>
To: Andrew Morton <akpm@zip.com.au>
Cc: linux-kernel@vger.kernel.org,
lse <lse-tech@lists.sourceforge.net>,
riel@conectiva.com.br, Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [RFC] Scalable statistics counters using kmalloc_percpu
Date: Tue, 30 Jul 2002 16:55:48 +0530 [thread overview]
Message-ID: <20020730165548.A1992@in.ibm.com> (raw)
In-Reply-To: <3D45880A.8C87A8E7@zip.com.au>; from akpm@zip.com.au on Mon, Jul 29, 2002 at 11:23:06AM -0700
On Mon, Jul 29, 2002 at 11:23:06AM -0700, Andrew Morton wrote:
> ...
> Well Rusty's point about just using the percpu API seemed
> reasonable - that's basically equivalent to statically defining
> the data. In what situation is dynamic allocation needed?
>
As Dipankar pointed out, counters part of dynamically allocated structures;
Like:
1. k_atm_dev_stats in atm_dev -- they are all atomic_t types right now.
we must see a major benefit with statctrs here.
I don't have access to atm infrastructure to test it though :(((
2. Atomic counters like dst->__refcnt; we might be able to hack
route cache so that the periodic garbage collector can tolerate
stale reads on the refcnt. A dst_entry might get gc'd late, nevertheless
it would boost performance on networking loads. (I still have to
investigate if we can do it at all...).
This is what I have in mind for now. Of course, if these primitives
are available to all, programmers will have more flexibility in
designing datastructures. We can then afford to have non atomic_t
global counters for debugging etc., anywhere in the kernel; modules/dynamic
structures...
Thanks,
Kiran
prev parent reply other threads:[~2002-07-30 11:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-26 15:10 [RFC] Scalable statistics counters using kmalloc_percpu Ravikiran G Thirumalai
2002-07-26 15:27 ` Rik van Riel
2002-07-26 15:54 ` [Lse-tech] " Dipankar Sarma
2002-07-29 14:18 ` Ravikiran G Thirumalai
2002-07-26 18:46 ` Andrew Morton
2002-07-26 19:46 ` William Lee Irwin III
2002-07-26 19:50 ` Robert Love
2002-07-26 19:53 ` William Lee Irwin III
2002-07-26 20:15 ` [Lse-tech] " William Lee Irwin III
2002-07-26 20:22 ` Robert Love
2002-07-27 12:00 ` Zwane Mwaikambo
2002-07-27 12:21 ` Zwane Mwaikambo
2002-07-28 21:33 ` Martin J. Bligh
2002-07-29 10:31 ` Zwane Mwaikambo
2002-07-29 14:54 ` Martin J. Bligh
2002-07-27 1:56 ` Rusty Russell
2002-07-27 4:45 ` Andrew Morton
2002-07-27 4:59 ` Rusty Russell
2002-07-27 6:16 ` Andrew Morton
2002-07-29 10:57 ` Ravikiran G Thirumalai
2002-07-29 18:23 ` Andrew Morton
2002-07-29 18:50 ` [Lse-tech] " Dipankar Sarma
2002-07-30 11:25 ` Ravikiran G Thirumalai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020730165548.A1992@in.ibm.com \
--to=kiran@in.ibm.com \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lse-tech@lists.sourceforge.net \
--cc=riel@conectiva.com.br \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox