Re: [BK PATCH] devfs cleanups for 2.5.29

Richard Gooch
2002-08-05T22:09:22Z

Roman Zippel writes:
> Hi,
>
> On Tue, 30 Jul 2002, Richard Gooch wrote:
>
> > > Are you sure it's save in devfs_open() too?
> >
> > Yes. RTFS.
>
> I'm trying - without getting headache.

Take a valium.

> In the "devfs=only" case, where is the module count incremented, when a
> block device is opened?

The module count is incremented when the device is opened,
irrespective of whether it's a character or block device, or even a
"regular" file.

> > > Even if it's save/fixed, it's still code duplication.
> >
> > No. I leverage fops_get(), a common function.
>
> Which is also insufficiently protected.

Incorrect.

Regards,

Richard....
Permanent: rgooch@atnf.csiro.au
Current: rgooch@ras.ucalgary.ca