Re: [BK PATCH] devfs cleanups for 2.5.29

Roman Zippel
2002-08-05T22:44:56Z

Hi,

On Mon, 5 Aug 2002, Richard Gooch wrote:

> > > Yes. RTFS.
> >
> > I'm trying - without getting headache.
>
> Take a valium.

Staying away from devfs sources is cheaper.

> > In the "devfs=only" case, where is the module count incremented, when a
> > block device is opened?
>
> The module count is incremented when the device is opened,
> irrespective of whether it's a character or block device, or even a
> "regular" file.

Would you please answer my question and tell me where that exactly
happens in that case?

> > > No. I leverage fops_get(), a common function.
> >
> > Which is also insufficiently protected.
>
> Incorrect.

What protects the module from unloading from getting the ops pointer until
try_inc_mod_count()?

bye, Roman