Re: [BK PATCH] devfs cleanups for 2.5.29

Roman Zippel
2002-08-21T11:18:21Z

Hi,

On Tue, 20 Aug 2002, Richard Gooch wrote:

> > Optimization??? This would require any device had to be be opened
> > _only_ through devfs, you are not seriously suggesting that???
>
> Huh? Of course not! All I'm saying is that if you use devfs, the
> optimisation will short-circuit the lookups.

Duplicating code paths like this doesn't count as optimization. Optimize
the common case and not the special case, so everyone can benefit from it.
Code duplication like this lets devfs suck so much. Anytime something is
changed in this area, devfs most likely needs to be fixed too.

bye, Roman