Re: [BK PATCH] devfs cleanups for 2.5.29

Greg KH
2002-07-30T23:44:29Z

On Tue, Jul 30, 2002 at 04:18:41PM -0700, Greg KH wrote:
> On Tue, Jul 30, 2002 at 05:12:07PM -0600, Richard Gooch wrote:
> >
> > Your patch misses the reason why I created those functions: some
> > drivers had to always register with the major table. With your
> > "fixups", those drivers will break when "devfs=only" is passed in. If
> > you first fix the drivers so that they work without an entry in the
> > major table, then your patch is safe to apply.
>
> Ah, then this "feature" should be written down somewhere. Which drivers
> does this happen for? And why penalize _all_ of the kernel drivers for
> only the few that need this?

Actually, in reading through the devfs documentation some more about the
"devfs=only" option, I think this patch should be accepted. Just
because you have not fixed up some remaining drivers for the (to quote
you) "dedicated souls" who want to use this option.

Don't force such a large and intrusive API change into loads of drivers
that do not want anything to do with devfs, just because your feature is
not yet complete.

If nothing else, it would force you (or people who actually use
"devfs=only") to fix those remaining drivers, which I would expect you
to view as a good thing :)

thanks,

greg k-h