From: "David S. Miller" <davem@redhat.com>
To: george@mvista.com
Cc: willy@debian.org, kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org
Subject: Re: softirq parameters
Date: Sun, 04 Aug 2002 22:37:46 -0700 (PDT) [thread overview]
Message-ID: <20020804.223746.89817190.davem@redhat.com> (raw)
In-Reply-To: <3D4D668F.3A29DD10@mvista.com>
From: george anzinger <george@mvista.com>
Date: Sun, 04 Aug 2002 10:38:23 -0700
Matthew Wilcox wrote:
> what do you guys think about this patch? nobody's using the data argument
> to the softirq routines, but most of the routines want to know which
> CPU they're running on.
I would vote no on this. While no one is currently using
the data argument, it would be _hard_ to replace it if it
were needed. The cpu, on the other hand, is available
regardless of it being passed or not and thus does not
_need_ to be passed.
I totally disagree. It is easy to put the specified argument back if
people really need it, because so FEW people use softirq's directly.
It's a 5 minute grep + edit job to put it back. Prove me wrong.
Next, show me one case where it is actually useful to be able to
specify this argument even theoretically! All such examples end
up being addresses or tables which could be made available to
the softint handler itself. Remember, softint's are only for
core subsystems and are to be used rarely. Tasklets foot the
bill for almost anything else.
Furthermore, this is one of the most important hot paths in
the entire kernel, any simplification and or improvement
in code generated to implement these paths is desirable.
I fully supporty Matthew's change.
next prev parent reply other threads:[~2002-08-05 5:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-04 16:26 softirq parameters Matthew Wilcox
2002-08-04 17:38 ` george anzinger
2002-08-05 5:37 ` David S. Miller [this message]
2002-08-07 5:24 ` Rusty Russell
2002-08-07 18:23 ` Matthew Wilcox
2002-08-07 18:18 ` David S. Miller
2002-08-07 18:35 ` Matthew Wilcox
2002-08-07 18:24 ` David S. Miller
2002-08-08 2:29 ` Rusty Russell
2002-08-08 5:13 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020804.223746.89817190.davem@redhat.com \
--to=davem@redhat.com \
--cc=george@mvista.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox