From: Russell King <rmk@arm.linux.org.uk>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: mporter@mvista.com, linux-kernel@vger.kernel.org
Subject: Re: Patch: linux-2.5.30/arch/arm/mach-iop310/iq80310-pci.c BUG_ON(cond1 || cond2) separation
Date: Mon, 5 Aug 2002 23:02:41 +0100 [thread overview]
Message-ID: <20020805230241.D16793@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20020805131740.A2433@baldur.yggdrasil.com>; from adam@yggdrasil.com on Mon, Aug 05, 2002 at 01:17:40PM -0700
On Mon, Aug 05, 2002 at 01:17:40PM -0700, Adam J. Richter wrote:
> I want to replace all statements in the kernel of the form
> BUG_ON(condition1 || condition2) with:
>
> BUG_ON(condition1);
> BUG_ON(condition2);
Why? In the case below, its one logical error (value out of range).
The register dump tells you more information. In fact, I don't care
which side of less than 1 or greater than 4 pin actually is. It's
indicating a bug in the PCI subsystem either way, and the analysis
is the same in either case.
> I was recently bitten by a very sporadic BUG_ON(cond1 || cond2)
> statement and was quite annoyed at the greatly reduced opportunity to
> debug the problem. Make these changes and someone who experiences
> the problem may be able to provide slightly more useful information.
This would make sense of the two conditions were unrelated to each
other.
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2002-08-05 21:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-05 20:17 Patch: linux-2.5.30/arch/arm/mach-iop310/iq80310-pci.c BUG_ON(cond1 || cond2) separation Adam J. Richter
2001-11-01 23:48 ` Pavel Machek
2002-08-07 22:06 ` Russell King
2002-08-05 22:02 ` Russell King [this message]
-- strict thread matches above, loose matches on Subject: below --
2002-08-06 1:25 Adam J. Richter
2002-08-08 5:53 Adam J. Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020805230241.D16793@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox