From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: "David S. Miller" <davem@redhat.com>,
linux-kernel@vger.kernel.org, vamsi_krishna@in.ibm.com
Subject: Re: [PATCH] kprobes for 2.5.30
Date: Tue, 06 Aug 2002 12:18:13 +1000 [thread overview]
Message-ID: <20020806035803.23FC54B65@lists.samba.org> (raw)
In-Reply-To: Your message of "Mon, 05 Aug 2002 09:10:08 MST." <Pine.LNX.4.44.0208050906030.1753-100000@home.transmeta.com>
In message <Pine.LNX.4.44.0208050906030.1753-100000@home.transmeta.com> you wri
te:
>
> On Mon, 5 Aug 2002, Rusty Russell wrote:
> >
> > In testing, I came up against the "spin_unlock() causes schedule()
> > inside interrupt" problem.
>
> It shouldn't cause a schedule, it should cause a big warning (with
> complete trace) to be printed out. Or did you mean something else?
Yes, that's what I meant.
> Maybe the warning should be changed to
>
> Warning, kernel is mixing metaphors. "It's not rocket surgery".
>
> to make it clear why it's a bad idea.
Oh yes, that's *much* clearer!
I am reading from this that we *should* be explicitly disabling
preemption in interrupt handlers if we rely on the cpu number not
changing underneath us, even if it's (a) currently unneccessary, and
(b) arch-specific code.
Yes?
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2002-08-06 3:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-02 2:11 [PATCH] kprobes for 2.5.30 Rusty Russell
2002-08-02 2:14 ` David S. Miller
2002-08-02 14:00 ` Vamsi Krishna S .
2002-08-05 4:14 ` Rusty Russell
2002-08-05 4:24 ` Linus Torvalds
2002-08-05 6:37 ` Rusty Russell
2002-08-05 16:10 ` Linus Torvalds
2002-08-06 2:18 ` Rusty Russell [this message]
2002-08-06 5:48 ` Linus Torvalds
2002-08-06 7:22 ` Rusty Russell
2002-08-06 7:59 ` Christoph Hellwig
2002-08-06 10:59 ` Vamsi Krishna S .
2002-08-06 11:12 ` Vamsi Krishna S .
2002-08-07 0:55 ` Rusty Russell
2002-08-07 4:59 ` Vamsi Krishna S .
2002-08-06 16:35 ` Linus Torvalds
2002-08-05 5:34 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020806035803.23FC54B65@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=vamsi_krishna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox