Re: [PATCH] 2.5.30 IDE 113

Petr Vandrovec
2002-08-06T10:31:56Z

On 6 Aug 02 at 12:20, Marcin Dalecki wrote:
> Uz.ytkownik Petr Vandrovec napisa?:
>
> > Hi Marcin,
> > what synchronizes these accesses to make sure that you do not have
> > two ide_raw_taskfile requests on the flight, both using same
> > drive->srequest? It looks to me like that nothing, so you can overwrite
> > request's contents while somebody else already uses this buffer.
>
> I don't think so. The queue lock is synchronizing them.
> And then we usually add them just to the front of the queue in question
> and wait for finishment until the request is done.

How queue lock can synchronize them if we do not hold queue lock
for entire duration and setup of request, including drive->srequest
setup?

> After all ide_raw_taskfile only gets used for REQ_SPECIAL request
> types. This does *not* contain normal data request from block IO.
> As of master slave issues - well we have the data pre allocated per
> device not per channel! If q->request_fn would properly return the
> error count instead of void, we could even get rid ot the
> checking for rq->errors after finishment... But well that's
> entierly different story.

For example do_cmd_ioctl() invokes ide_raw_taskfile, without any locking.
Two programs, both issuing HDIO_DRIVE_CMD at same time, will compete
over one drive->srequest struct: you'll get same drive->srequest structure
submitted twice to blk_insert_request (hm, Jens, will this trigger
BUG, or will this just damage request list?).
Petr Vandrovec
vandrove@vc.cvut.cz