Re: AIO together with SMPtimers-A0 oops and freezing

[Benjamin LaHaise <bcrl@redhat.com>]

On Mon, Aug 05, 2002 at 07:20:29PM +0200, Marc-Christian Petersen wrote:
> Hi Ben, Hi Ingo,

> Ben, I am using your AIO 20020619 patch + relevant fixes from the AIO 
> mailinglist together with your patch Ingo, SMPtimers-A0.

Hmmm, the only problem I can see in the aio code wrt timer usage is 
the following.  Does this patch make a difference?  If not, I'm guessing 
that the problem is something in SMPtimers-A0 that aio happens to 
trigger.  The only timer aio uses is for the timeout when waiting for an 
event, and the structure for that is put on the stack.

		-ben


Index: aio.c
===================================================================
RCS file: /bcrl/cvs/CVSROOT/net-aio/linux/fs/aio.c,v
retrieving revision 1.13
diff -u -u -r1.13 aio.c
--- aio.c	6 Aug 2002 20:02:23 -0000	1.13
+++ aio.c	6 Aug 2002 20:04:40 -0000
@@ -774,8 +774,10 @@
 			goto out;
 
 		set_timeout(&to, &ts);
-		if (to.timed_out)
+		if (to.timed_out) {
 			timeout = 0;
+			clear_timeout(&to);
+		}
 	}
 
 	while (likely(i < nr)) {