public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: rusty@rustcorp.com.au
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpumask_t
Date: Thu, 08 Aug 2002 07:36:30 -0700 (PDT)	[thread overview]
Message-ID: <20020808.073630.37512884.davem@redhat.com> (raw)
In-Reply-To: <20020808074422.E414A4ADA@lists.samba.org>

   From: Rusty Russell <rusty@rustcorp.com.au>
   Date: Thu, 08 Aug 2002 17:39:18 +1000

   I've tested this now with making cpumask_t a struct, and it works fine
   (at the moment it's unsigned long for every arch, no change).

It worked because you cast the thing to (unsigned long *) in every
bitops.  We either:

1) shouldn't need to do that, meaning cpumask_t must be a long
   or array or longs

2) you need to abstract away bitops on cpumask_t so that one
   _really_ could make cpumask_t a struct with things other
   than the mask itself inside, so cpumask_test, cpumask_add,
   cpumask_remove or however you'd like to name them

Didn't we go through a lot of effort to sanitize bitops types
and kill the ugly casts? :-))))


  reply	other threads:[~2002-08-08 14:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-08-08  7:39 [PATCH] cpumask_t Rusty Russell
2002-08-08 14:36 ` David S. Miller [this message]
2002-08-09  6:04   ` Rusty Russell
2002-08-09 10:10     ` Brad Heilbrun
2003-01-19 21:35     ` William Lee Irwin III
2003-01-19 22:18       ` William Lee Irwin III
2003-01-19 22:43         ` William Lee Irwin III
2003-01-19 22:54           ` William Lee Irwin III
2003-02-10  7:06             ` William Lee Irwin III
2003-01-20  6:10       ` David S. Miller
2003-01-20  6:32         ` William Lee Irwin III
2003-01-20  6:24           ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20020808.073630.37512884.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox