Re: RFC: PCI hotplug resource reservation

[Greg KH <greg@kroah.com>]

On Tue, Aug 06, 2002 at 05:16:30PM -0400, Scott Murray wrote:
> I've been using this for several weeks now, and it allows me to hot
> insert new devices quite well.  However, my goal for my CompactPCI work
> is to get it into the mainline kernel so people can add drivers for
> other boards and chassis on top of it.  If this resource reservation
> scheme is too distasteful, or there is indeed a "cleaner" way, I'd
> really like comments or suggestions before I push on much further.

Hm, now that it looks like this is going to be necessary for cPCI
hotplug drivers, could you make up a 2.5 version of it?

The code should only be compiled in if CONFIG_HOTPLUG_PCI_CPCI is
enabled, and hopefully with the splitup of the PCI code in the 2.5 tree,
you should be able to contain it to one file, much like this patch has.

One small comment:

> @@ -2031,6 +2031,10 @@
>  	struct pci_dev *dev;
> 
>  	pcibios_init();
> +
> +#ifdef CONFIG_HOTPLUG_PCI
> +	pci_hp_reserve_resources();
> +#endif

Move this #ifdef to a header file file, so it doesn't show up in the .c
file.

thanks,

greg k-h