From: Russell King <rmk@arm.linux.org.uk>
To: Albert Cranford <ac9410@attbi.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: [patch 3/4] 2.5.30 i2c updates
Date: Fri, 9 Aug 2002 09:40:10 +0100 [thread overview]
Message-ID: <20020809094010.A29805@flint.arm.linux.org.uk> (raw)
In-Reply-To: <3D53359B.BC5980FB@attbi.com>; from ac9410@attbi.com on Thu, Aug 08, 2002 at 11:23:07PM -0400
btw, I'm Russell, not Rusty. 8)
On Thu, Aug 08, 2002 at 11:23:07PM -0400, Albert Cranford wrote:
> --- linux-2.5.26/drivers/i2c/i2c-elektor.c.orig 2002-07-05 19:42:02.000000000 -0400
> +++ linux/drivers/i2c/i2c-elektor.c 2002-08-07 22:39:08.000000000 -0400
>...
> @@ -121,12 +118,12 @@
> int timeout = 2;
>
> if (irq > 0) {
> - cli();
> + spin_lock_irq(&irq_driver_lock);
> if (pcf_pending == 0) {
> interruptible_sleep_on_timeout(&pcf_wait, timeout*HZ );
Two points here:
- Sleeping with interrupts disabled.
- Use of interruptible_sleep_on_timeout().
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
prev parent reply other threads:[~2002-08-09 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-09 3:23 [patch 3/4] 2.5.30 i2c updates Albert Cranford
2002-08-09 8:40 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020809094010.A29805@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=ac9410@attbi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox