Re: [patch 6/12] hold atomic kmaps across generic_file_read

Linus Torvalds
2002-08-11T00:51:35Z

On Sat, 10 Aug 2002, Andrew Morton wrote:
>
> If not, I don't think it's worth making this change just for
> the highmem read/write thing (calculating `current' at each
> spin_lock site...) I just open coded it.

Well, this way it will now do the preempt count twice (once in
kmap_atomic, once in th eopen-coded one) if preempt is enabled.

I'd suggest just making k[un]map_atomic() always do the
inc/dec_preempt_count. Other ideas?

Linus