From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@zip.com.au>
Cc: Linus Torvalds <torvalds@transmeta.com>,
lkml <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@redhat.com>
Subject: Re: [patch 2/21] reduced locking in buffer.c
Date: Tue, 13 Aug 2002 18:52:13 +0100 [thread overview]
Message-ID: <20020813185213.A17449@infradead.org> (raw)
In-Reply-To: <3D5947B7.EDE01C2E@zip.com.au>; from akpm@zip.com.au on Tue, Aug 13, 2002 at 10:53:59AM -0700
On Tue, Aug 13, 2002 at 10:53:59AM -0700, Andrew Morton wrote:
> I have discussed it with David - he said it's OK in 2.5, but
> not in 2.4, and he has eyeballed the diff.
>
> However there's another thing to think about:
>
> local_irq_disable();
> atomic_inc();
>
> If the architecture implements atomic_inc with spinlocks, this will
> schedule with interrupts off with CONFIG_PREEMPT=y, I expect.
>
> I can fix that with a preempt_disable() in there, but ick.
Is there a reason you can't just use brlocks?
next prev parent reply other threads:[~2002-08-13 17:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-11 7:38 [patch 2/21] reduced locking in buffer.c Andrew Morton
2002-08-13 17:34 ` Linus Torvalds
2002-08-13 17:34 ` David S. Miller
2002-08-13 17:53 ` Andrew Morton
2002-08-13 17:52 ` Christoph Hellwig [this message]
2002-08-13 18:09 ` Andrew Morton
2002-08-14 8:36 ` William Lee Irwin III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020813185213.A17449@infradead.org \
--to=hch@infradead.org \
--cc=akpm@zip.com.au \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox