From: Pete Zaitcev <zaitcev@redhat.com>
To: "Jason Zebchuk" <jason@consensys.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci_do_scan_bus
Date: Tue, 13 Aug 2002 15:08:42 -0400 [thread overview]
Message-ID: <200208131908.g7DJ8g817440@devserv.devel.redhat.com> (raw)
In-Reply-To: <mailman.1029261839.22627.linux-kernel2news@redhat.com>
> --- linux-2.5.30/drivers/pci/probe.c Thu Aug 1 17:16:10 2002
> +++ linux/drivers/pci/probe.c Tue Aug 6 12:36:53 2002
> /* Create a device template */
> - memset(&dev0, 0, sizeof(dev0));
> - dev0.bus = bus;
> + dev0 = kmalloc(sizeof(struct pci_dev), GFP_ATOMIC);
> + if (dev0 == NULL)
> + BUG();
> + memset(dev0, 0, sizeof(dev0));
> + dev0->bus = bus;
Why is this atomic? I think we do not scan from interrupts,
only from init/swapper and insmod contexts.
-- Pete
next parent reply other threads:[~2002-08-13 19:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <mailman.1029261839.22627.linux-kernel2news@redhat.com>
2002-08-13 19:08 ` Pete Zaitcev [this message]
2002-08-13 16:52 [PATCH] pci_do_scan_bus Jason Zebchuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200208131908.g7DJ8g817440@devserv.devel.redhat.com \
--to=zaitcev@redhat.com \
--cc=jason@consensys.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox