Re: [PATCH] NUMA-Q disable irqbalance

Martin J. Bligh
2002-08-13T17:13:25Z

>> This patch is from Matt Dobson. It disables irq_balance for the NUMA-Q
>> and makes it a config option for everyone else.
>
> Please don't use negative config options.
>
> I'd much rather have
>
> bool 'IRQ balancing support' CONFIG_IRQ_BALANCE
>
> than some "Disable IRQ balancing?" question.

That piece of wierdness I'll take the blame for, not Matt. It's more complex, we
just wanted to make the default be to have it turned on, maybe we've missed
some way in the config to make it work like that?

> Also, the explanation should probably explain that a P4 needs manual IRQ
> balancing since the P4 broke the Intel-documented round-robin behaviour.
>
> Finally, exactly since IRQ balancing is practically required on P4-SMP, I
> really don't think a CONFIG option works. It needs to be configured in on
> any kernel that expects to use P4's in an SMP configuration.

That'd be easier if it was written in such a way it worked on all P4 systems.
For one, it does an rdtsc directly, which doesn't work on all machines.
For another, it assumes flat logical addressing mode. We need to be able
to disable this until it's rewritten in such a way as to be more generic.

> In other words, I think this needs to do a dynamic disable (with the
> possible exception of a NUMA-Q machine, since that one is already a static
> config option and won't have P4's in it).

Was there some reason you really need this on P4s? I seem to recall something
to do with timer interrupts, but don't remember exactly.

M.

PS. I think __DO_ACTION gets an award for disgusting use of macros.