Re: [PATCH] NUMA-Q disable irqbalance

Martin J. Bligh
2002-08-14T05:49:39Z

> But this is exactly the kinds of cases that config options do
> _not_ work well for.

OK ... you're right ;-) This is bad, especially for distribution
kernels. So I just need something to stop the NUMA-Q crashing.
Can I have the appended? Please, please, please? ;-)
It just adds an if switch to irq_balance which the compiler
optimises away anyway. Not a whiff of a config option.
Tested on 2.5.31.

M.

diff -urN -X /home/mbligh/.diff.exclude 2.5.31-virgin/arch/i386/kernel/io_apic.c 2.5.31-irqbalance2/arch/i386/kernel/io_apic.c
--- 2.5.31-virgin/arch/i386/kernel/io_apic.c Sat Aug 10 18:41:26 2002
+++ 2.5.31-irqbalance2/arch/i386/kernel/io_apic.c Tue Aug 13 22:32:49 2002
@@ -251,6 +251,9 @@
irq_balance_t *entry = irq_balance + irq;
unsigned long now = jiffies;

+ if (clustered_apic_mode)
+ return;
+
if (entry->timestamp != now) {
unsigned long allowed_mask;
int random_number;