Re: [PATCH] 2.5.31 driverfs: patch for your consideration

[Greg KH <greg@kroah.com>]

On Fri, Aug 16, 2002 at 10:36:00PM +0000, Adam Belay wrote:
> Here's the patch as we discussed.

Um, your email client mangled the patch, dropping tabs and wrapped
lines.

> +static ssize_t device_read_driver(struct device * dev, char * buf, 
> size_t count, loff_t off)
> +{
> +    if (dev->driver)
> +        return off ? 0 : sprintf(buf,"%s\n",dev->driver->name);
> +    else
> +        return 0;
> +}

Isn't this info already in the "name" file of a driver?


> +struct device_driver * find_driver_by_name(struct bus_type * bus, char 
> * name)
> +{
> +    struct list_head * pos;
> +    struct device_driver * drv;
> +    list_for_each (pos, &bus->drivers)
> +    {
> +        drv = list_entry(pos, struct device_driver, bus_list);
> +        if (!strncmp(drv->name,name,strlen(name) - 1))
> +            return drv;
> +
> +    }
> +    return NULL;
> +
> +}

Not that I agree with this patch at all, but you might want to go read
Documentation/CodingStyle to fix up your brace placement properly.

thanks,

greg k-h