From: Benjamin LaHaise <bcrl@redhat.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] reduce stack usage of sanitize_e820_map
Date: Sat, 17 Aug 2002 15:17:04 -0400 [thread overview]
Message-ID: <20020817151704.A3894@redhat.com> (raw)
In-Reply-To: <m11y8xqu98.fsf@frodo.biederman.org>; from ebiederm@xmission.com on Sat, Aug 17, 2002 at 11:18:11AM -0600
On Sat, Aug 17, 2002 at 11:18:11AM -0600, Eric W. Biederman wrote:
> Benjamin LaHaise <bcrl@redhat.com> writes:
>
> > Hello,
> >
> > Currently, sanitize_e820_map uses 0x738 bytes of stack. The patch below
> > moves the arrays into __initdata, reducing stack usage to 0x34 bytes.
>
> Can we keep the arrays in sanitize_e820_map and just mark then static
> and __initdata? That would appear to be a cleaner solution.
> Polluting the global kernel name space with these is not nice.
Nope. static conflicts with __initdata. If namespace pollution is a
concern, just prefix them with e820_.
-ben
--
"You will be reincarnated as a toad; and you will be much happier."
next prev parent reply other threads:[~2002-08-17 19:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-15 21:48 [patch] reduce stack usage of sanitize_e820_map Benjamin LaHaise
2002-08-16 14:58 ` Denis Vlasenko
2002-08-16 15:27 ` Linus Torvalds
2002-08-17 17:18 ` Eric W. Biederman
2002-08-17 19:17 ` Benjamin LaHaise [this message]
2002-08-17 19:35 ` Benjamin LaHaise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020817151704.A3894@redhat.com \
--to=bcrl@redhat.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox