From: "H. J. Lu" <hjl@lucon.org>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Jeff Garzik <jgarzik@mandrakesoft.com>, dhinds <dhinds@sonic.net>,
linux kernel <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: New fix for CardBus bridge behind a PCI bridge
Date: Sun, 18 Aug 2002 07:28:16 -0700 [thread overview]
Message-ID: <20020818072816.A19927@lucon.org> (raw)
In-Reply-To: <20020818144948.A1241@localhost.park.msu.ru>; from ink@jurassic.park.msu.ru on Sun, Aug 18, 2002 at 02:49:48PM +0400
On Sun, Aug 18, 2002 at 02:49:48PM +0400, Ivan Kokshaysky wrote:
> On Sat, Aug 17, 2002 at 08:36:01AM -0700, H. J. Lu wrote:
> > It could be. But I doubt it. At least, I don't think you can treat a
> > AGP bridge like a 82801BAM/CAM bridge. I think 82801BAM/CAM is a
> > special case. You really have to read the datasheet to know for sure.
>
> You're right by all means. AGP bridges are _always_ positive decoders.
> The problems you've seen were caused by the wrong semicolon somehow
> sneaked into the patch:
>
> +static void __init pci_fixup_transparent_bridge(struct pci_dev *dev)
> +{
> + if ((dev->class >> 8) == PCI_CLASS_BRIDGE_PCI &&
> + (dev->device & 0xff00) == 0x2400);
> ^ Ugh..
> + dev->class |= 1;
> +}
>
> Which means that I'm setting bit 0 in the ProgIf for _all_ Intel devices...
> I'm really sorry about that.
Yes. It works now. Thanks.
H.J.
prev parent reply other threads:[~2002-08-18 14:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20020806105023.A17451@lucon.org>
[not found] ` <20020806112636.A29360@sonic.net>
[not found] ` <20020806130420.A19613@lucon.org>
[not found] ` <20020809160506.A19549@sonic.net>
[not found] ` <20020809164835.B21110@lucon.org>
[not found] ` <20020809172140.A30911@sonic.net>
[not found] ` <20020810222355.A13749@lucon.org>
2002-08-12 17:49 ` PATCH: Fix CardBus bridge behind a PCI bridge H. J. Lu
[not found] ` <20020812110431.A14125@sonic.net>
[not found] ` <20020812112911.A18947@lucon.org>
[not found] ` <20020812122158.A27172@sonic.net>
2002-08-12 21:07 ` H. J. Lu
[not found] ` <20020812154851.A20073@sonic.net>
2002-08-13 3:29 ` PATCH: New fix for " H. J. Lu
2002-08-16 15:48 ` Ivan Kokshaysky
2002-08-17 5:49 ` H. J. Lu
2002-08-17 14:55 ` Ivan Kokshaysky
2002-08-17 15:26 ` Jeff Garzik
2002-08-17 15:36 ` H. J. Lu
2002-08-18 10:49 ` Ivan Kokshaysky
2002-08-18 14:28 ` H. J. Lu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020818072816.A19927@lucon.org \
--to=hjl@lucon.org \
--cc=dhinds@sonic.net \
--cc=ink@jurassic.park.msu.ru \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox