From: Jeff Dike <jdike@karaya.com>
To: James Morris <jmorris@intercode.com.au>
Cc: "David S. Miller" <davem@redhat.com>,
kuznet@ms2.inr.ac.ru, Andi Kleen <ak@muc.de>,
viro@math.psu.edu, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@debian.org>
Subject: Re: [PATCH][RFC] sigurg/sigio cleanup for 2.5.31 [version 2]
Date: Sun, 18 Aug 2002 21:28:18 -0500 [thread overview]
Message-ID: <200208190228.VAA04400@ccure.karaya.com> (raw)
In-Reply-To: Your message of "Sat, 17 Aug 2002 12:58:12 +1000." <Mutt.LNX.4.44.0208171249510.3437-100000@blackbird.intercode.com.au>
This is still wrong. You need to be checking fown->pid in the loop.
Same thing in send_sigurg.
Jeff
@@ -469,6 +492,12 @@
struct task_struct * p;
int pid = fown->pid;
+ if (!pid)
+ return;
+
+ while (pid == PID_INVALID)
+ cpu_relax();
+
read_lock(&tasklist_lock);
if ( (pid > 0) && (p = find_task_by_pid(pid)) ) {
send_sigio_to_task(p, fown, fd, band);
next prev parent reply other threads:[~2002-08-19 1:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-15 17:16 [PATCH][RFC] sigurg/sigio cleanup for 2.5.31 James Morris
2002-08-15 19:04 ` Matthew Wilcox
2002-08-16 0:10 ` James Morris
2002-08-15 22:36 ` kuznet
2002-08-16 13:07 ` James Morris
2002-08-16 14:50 ` kuznet
2002-08-16 15:03 ` James Morris
2002-08-16 15:16 ` kuznet
2002-08-16 7:06 ` Chris Wright
2002-08-16 16:25 ` Jeff Dike
2002-08-16 15:59 ` James Morris
2002-08-17 18:16 ` Alan Cox
2002-08-18 0:57 ` James Morris
2002-08-19 1:16 ` James Morris
2002-08-17 2:58 ` [PATCH][RFC] sigurg/sigio cleanup for 2.5.31 [version 2] James Morris
2002-08-19 2:28 ` Jeff Dike [this message]
2002-08-19 1:37 ` James Morris
2002-08-19 10:14 ` [PATCH][RFC] sigurg/sigio cleanup for 2.5.31 [version 3] James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200208190228.VAA04400@ccure.karaya.com \
--to=jdike@karaya.com \
--cc=ak@muc.de \
--cc=davem@redhat.com \
--cc=jmorris@intercode.com.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@math.psu.edu \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox