From: Benjamin LaHaise <bcrl@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk simultaneous oops disentangling
Date: Thu, 22 Aug 2002 11:57:29 -0400 [thread overview]
Message-ID: <20020822115729.C16763@redhat.com> (raw)
In-Reply-To: <20020822115114.B16763@redhat.com>; from bcrl@redhat.com on Thu, Aug 22, 2002 at 11:51:14AM -0400
On Thu, Aug 22, 2002 at 11:51:14AM -0400, Benjamin LaHaise wrote:
> On Thu, Aug 22, 2002 at 01:09:18PM +0100, David Howells wrote:
> > Hi Linus,
> >
> > Here's a patch to stop multiple simultaneous oopses on an SMP system from
> > interleaving with and overwriting bits of each other. It only permits lock
> > breaking if the printk lock is held by the same CPU.
>
> This is still wrong. It should attempt to acquire the locks with a timeout
> before trampling on them, as there may be a printk or other console output
> in progress on the other cpu.
/me must be having a bad week
The patch is actually right, but bust_spinlocks still blindly stops on locks
that may not need to be stomped on.
-ben
--
"You will be reincarnated as a toad; and you will be much happier."
prev parent reply other threads:[~2002-08-22 15:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-22 12:09 [PATCH] printk simultaneous oops disentangling David Howells
2002-08-22 15:51 ` Benjamin LaHaise
2002-08-22 15:57 ` Benjamin LaHaise [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020822115729.C16763@redhat.com \
--to=bcrl@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox